Skip to content

Commit 4cb7bc1

Browse files
etkmaozealotchen0
authored andcommitted
fix(core): check crash on config SetScaleFactor (#3967)
1 parent fc11e02 commit 4cb7bc1

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

dom/src/dom/taitank_layout_node.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -648,7 +648,9 @@ void TaitankLayoutNode::SetPosition(Edge edge, float position) {
648648
void TaitankLayoutNode::SetScaleFactor(float sacle_factor) {
649649
assert(engine_node_ != nullptr);
650650
TaitankConfigRef config = engine_node_->GetConfig();
651-
config->SetScaleFactor(sacle_factor);
651+
if (config) {
652+
config->SetScaleFactor(sacle_factor);
653+
}
652654
}
653655

654656
void TaitankLayoutNode::SetMaxWidth(float max_width) {
@@ -821,6 +823,7 @@ void TaitankLayoutNode::Allocate() { engine_node_ = new TaitankNode(); }
821823
void TaitankLayoutNode::Deallocate() {
822824
if (engine_node_ == nullptr) return;
823825
delete engine_node_;
826+
engine_node_ = nullptr;
824827
}
825828

826829
void InitLayoutConsts() {

0 commit comments

Comments
 (0)