fix(android): add ControllerRegistry destroy

siguangli2018 · siguangli2018 · commit 2c73ba0360f5 · 2024-11-04T10:46:04.000+08:00
diff --git a/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerManager.java b/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerManager.java
@@ -178,8 +178,8 @@ public HippyCustomPropsController getCustomPropsController() {
     }
 
     public void destroy() {
-        mControllerRegistry.clear();
-        mControllerUpdateManger.clear();
+        mControllerRegistry.destroy();
+        mControllerUpdateManger.destroy();
         for (Pool<Integer, View> pool : mPreCreateViewPools.values()) {
             pool.clear();
         }
diff --git a/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerRegistry.java b/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerRegistry.java
@@ -49,7 +49,11 @@ public ControllerRegistry(@NonNull Renderer renderer) {
         mRendererWeakRef = new WeakReference<>(renderer);
     }
 
-    public void clear() {}
+    void destroy() {
+        mViews.clear();
+        mRootViews.clear();
+        mControllers.clear();
+    }
 
     public void addControllerHolder(String name, ControllerHolder controllerHolder) {
         mControllers.put(name, controllerHolder);
diff --git a/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerUpdateManger.java b/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerUpdateManger.java
@@ -83,7 +83,7 @@ public ControllerUpdateManger(@NonNull Renderer renderer) {
         mRendererWeakRef = new WeakReference<>(renderer);
     }
 
-    public void clear() {
+    void destroy() {
 
     }
 

Original file line number	Diff line number	Diff line change
`@@ -178,8 +178,8 @@ public HippyCustomPropsController getCustomPropsController() {`
`178`	`178`	`}`
`179`	`179`
`180`	`180`	`public void destroy() {`
`181`		`- mControllerRegistry.clear();`
`182`		`- mControllerUpdateManger.clear();`
	`181`	`+ mControllerRegistry.destroy();`
	`182`	`+ mControllerUpdateManger.destroy();`
`183`	`183`	`for (Pool<Integer, View> pool : mPreCreateViewPools.values()) {`
`184`	`184`	`pool.clear();`
`185`	`185`	`}`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public ControllerUpdateManger(@NonNull Renderer renderer) {`
`83`	`83`	`mRendererWeakRef = new WeakReference<>(renderer);`
`84`	`84`	`}`
`85`	`85`
`86`		`- public void clear() {`
	`86`	`+ void destroy() {`
`87`	`87`
`88`	`88`	`}`
`89`	`89`