Repository navigation
fix(extension): preserve plus keys in keyboard chords - #308
Conversation
|
Thanks for the focused fix! Validation against main (8ca7911) confirms that the issue still exists and that this patch fixes the intended Ctrl++ / Cmd++ cases.
Could we restrict the new plus-key handling to cases where the preceding tokens are all recognized modifiers? That would preserve the intended fix while avoiding these additional behavior changes. Please also add regression coverage confirming that unknown-prefix cases return invalid_params without dispatching any key events, and that an existing base key is not overwritten by the new handling. A small guard around the new branch should be sufficient here. With that adjustment and coverage, I’d be happy to move this toward merge. |
bsk press 'Ctrl++'currently fails withunknown key "Ctrl++": splitting on+drops the base key.Ctrl+Shift++andCmd++fail for the same reason, even though a separate+key with explicit modifiers already works.Preserve the trailing literal
+before parsing modifiers. The regression tests cover compound forms, aliases, whitespace, and the plain+key. A handler test also checks thatCtrl++dispatches exactly the same events as+with an explicit Ctrl modifier.Validation:
Ctrl++fails.