fix(proofofwork): de-flake JavaScript loading in Google Chrome - #1807
Merged
Conversation
Load JavaScript using `defer` instead of `async`. This fixes a rare race condition that can happen when Chrome finishes downloading the challenge JavaScript before finishing page rendering. I was not able to reproduce this in testing, possibly due to my setup being incredibly low-latency. Closes: #1782 Signed-off-by: Xe Iaso <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load JavaScript using
deferinstead ofasync. This fixes a rare race condition that can happen when Chrome finishes downloading the challenge JavaScript before finishing page rendering.I was not able to reproduce this in testing, possibly due to my setup being incredibly low-latency.
Closes: #1782
Checklist:
[Unreleased]section of docs/docs/CHANGELOG.mdnpm run test:integration(unsupported on Windows, please use WSL)