fix(lib): rename cookies based on settings - #1798
Merged
Merged
Conversation
Cookies are horrible: a rant by Xe Iaso. Cookies are horrible. When cookies are sent from server to client, they include a number of settings that I mistakenly let administrators control. Turns out that when the browser stores them, they uniquely identify cookies by the combination of both name and settings. These settings are not sent back to the server upon requests. As a result, if any administator changes any cookie setting without changing the cookie name, the client sends two cookies. This is not good because the server tries to clear the errant cookie, but the client discards that because it doesn't match what the server sent. To fix this, cookies are now dynamically renamed based on cookie settings. This behaviour cannot be disabled. Ref: #1797 Ref: #1701 Signed-off-by: Xe Iaso <[email protected]>
4 tasks
|
Including the hash in the cookie name breaks the advanced haproxy setup since it's now no longer (easily) possible to know what cookie to look for. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cookies are horrible: a rant by Xe Iaso.
Cookies are horrible. When cookies are sent from server to client, they include a number of settings that I mistakenly let administrators control. Turns out that when the browser stores them, they uniquely identify cookies by the combination of both name and settings. These settings are not sent back to the server upon requests. As a result, if any administator changes any cookie setting without changing the cookie name, the client sends two cookies. This is not good because the server tries to clear the errant cookie, but the client discards that because it doesn't match what the server sent.
To fix this, cookies are now dynamically renamed based on cookie settings. This behaviour cannot be disabled.
Ref: #1797
Ref: #1701
Checklist:
[Unreleased]section of docs/docs/CHANGELOG.mdnpm run test:integration(unsupported on Windows, please use WSL)