Repository navigation
Commit 4a08a54
authored
[material_ui] Unskip web tests that pass on CanvasKit and Skwasm: app_bar_theme_test, input_decorator_test, paginated_data_table_test, spell_check_suggestions_toolbar_test (flutter#13352)
Removes web skips (`skip: kIsWeb` / `skip: isBrowser`) from tests in `packages/material_ui/test` that now pass on Chrome with both CI web renderers, CanvasKit (dart2js) and Skwasm (dart2wasm). Leaving them skipped hides web regressions.
- `app_bar_theme_test.dart`: the `AppBarThemeData implements debugFillProperties` test. Doubles now print the same on web as on other platforms. Also removes the comment that explained the old skip.
- `input_decorator_test.dart`: 8 tests: the `OutlineInputBorder` paint/path tests (skipped for #55317) and the `textWidthBasis` clip tests (skipped for #44020).
- `paginated_data_table_test.dart`: the large text test (skipped for #43433). It no longer times out.
- `spell_check_suggestions_toolbar_test.dart`: `more than three suggestions throws an error`. Also removes the `package:flutter/foundation.dart` import, which is unused now.
None of the unskipped tests use goldens.
Fixes flutter/flutter#43433
Fixes flutter/flutter#44020
Fixes flutter/flutter#55317
Related issues:
- flutter/flutter#87364
This PR changes tests only, so it is exempt from version and CHANGELOG updates.
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.1 parent 1383427 commit 4a08a54
4 files changed
Lines changed: 26 additions & 37 deletions
File tree
- packages/material_ui/test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1204 | 1204 | | |
1205 | 1205 | | |
1206 | 1206 | | |
1207 | | - | |
1208 | | - | |
1209 | | - | |
1210 | | - | |
1211 | | - | |
1212 | | - | |
1213 | | - | |
| 1207 | + | |
1214 | 1208 | | |
1215 | 1209 | | |
1216 | 1210 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1747 | 1747 | | |
1748 | 1748 | | |
1749 | 1749 | | |
1750 | | - | |
| 1750 | + | |
1751 | 1751 | | |
1752 | 1752 | | |
1753 | 1753 | | |
| |||
1786 | 1786 | | |
1787 | 1787 | | |
1788 | 1788 | | |
1789 | | - | |
| 1789 | + | |
1790 | 1790 | | |
1791 | 1791 | | |
1792 | 1792 | | |
| |||
1850 | 1850 | | |
1851 | 1851 | | |
1852 | 1852 | | |
1853 | | - | |
| 1853 | + | |
1854 | 1854 | | |
1855 | 1855 | | |
1856 | 1856 | | |
| |||
3217 | 3217 | | |
3218 | 3218 | | |
3219 | 3219 | | |
3220 | | - | |
| 3220 | + | |
3221 | 3221 | | |
3222 | 3222 | | |
3223 | 3223 | | |
| |||
15056 | 15056 | | |
15057 | 15057 | | |
15058 | 15058 | | |
15059 | | - | |
| 15059 | + | |
15060 | 15060 | | |
15061 | 15061 | | |
15062 | 15062 | | |
| |||
15101 | 15101 | | |
15102 | 15102 | | |
15103 | 15103 | | |
15104 | | - | |
| 15104 | + | |
15105 | 15105 | | |
15106 | 15106 | | |
15107 | 15107 | | |
| |||
15172 | 15172 | | |
15173 | 15173 | | |
15174 | 15174 | | |
15175 | | - | |
| 15175 | + | |
15176 | 15176 | | |
15177 | 15177 | | |
15178 | 15178 | | |
| |||
15329 | 15329 | | |
15330 | 15330 | | |
15331 | 15331 | | |
15332 | | - | |
| 15332 | + | |
15333 | 15333 | | |
15334 | 15334 | | |
15335 | 15335 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
577 | 577 | | |
578 | 578 | | |
579 | 579 | | |
580 | | - | |
| 580 | + | |
581 | 581 | | |
582 | 582 | | |
583 | 583 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
76 | 75 | | |
77 | 76 | | |
78 | 77 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
90 | 86 | | |
91 | 87 | | |
92 | | - | |
93 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
94 | 91 | | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
102 | 97 | | |
103 | 98 | | |
104 | 99 | | |
| |||
0 commit comments