Refactor Dockerfile.orin dependency layers #110#111
Merged
Yunus-Selim merged 2 commits intoTeam-Isaac-Polito:mainfrom Apr 22, 2026
Merged
Refactor Dockerfile.orin dependency layers #110#111Yunus-Selim merged 2 commits intoTeam-Isaac-Polito:mainfrom
Yunus-Selim merged 2 commits intoTeam-Isaac-Polito:mainfrom
Conversation
Yunus-Selim
force-pushed
the
issue-110-cleanup-dockerfile-orin
branch
from
b85cd5f to
8311aac
Compare
Yunus-Selim
approved these changes
Apr 22, 2026
Contributor
Yunus-Selim
left a comment
Yunus-Selim
left a comment
There was a problem hiding this comment.
Thank you for the contribution and sorry for the late return.
Because of some compatibility issues, we will have to keep the ros2 libraries in Dockerfile.orin. So, I had to modify it a little bit.
Other than that, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up
docker/Dockerfile.orinby reducing redundant installs, consolidating dependency layers, and making dev/debug tooling easier to exclude.Changes
reseq-basethat are already declared in the workspacepackage.xmlfiles and can be resolved byrosdepin the final stagenumpy==1.23.5installationINSTALL_DEV_TOOLS=truerm -rf /var/lib/apt/lists/*cleanup to apt install blocksNotes
The Dockerfile now keeps
reseq-basefocused on image-specific extras, while workspace-declared ROS dependencies are left torosdep install --from-path srcin the finalreseqstage.A slimmer build can now be produced with:
docker build -t reseq-orin -f docker/Dockerfile.orin --build-arg INSTALL_DEV_TOOLS=false .