Skip to content

Conversation

@mahmudhamid
Copy link
Contributor

@mahmudhamid mahmudhamid commented Sep 8, 2024

#5739

Updated the following incomplete feature guides:

  1. docs/guide/expanding.md
  2. docs/guide/fuzzy-filtering.md
  3. docs/guide/global-faceting.md
  4. docs/guide/global-filtering.md
  5. docs/guide/grouping.md

Content is based on my current understanding of the TanStack table library. It may not be full and comprehensive but at least include the essentials.

@KevinVandy
Copy link
Member

Impressive following through. Feel free to open up your GitHub sponsors if you live somewhere that allows that, especially if you plan to contribute more.

Modified some information for clarity
Fixed some typos
fixed some typos
@mahmudhamid
Copy link
Contributor Author

mahmudhamid commented Sep 9, 2024

Impressive following through. Feel free to open up your GitHub sponsors if you live somewhere that allows that, especially if you plan to contribute more.

Thanks Kevin. Sponsorships are not available in my region. I'm certainly eager to contribute more whenever possible.

@KevinVandy
Copy link
Member

It's ok to use AI to help write the docs, but we need to make sure that we don't leave any hallucinations in it.

@mahmudhamid
Copy link
Contributor Author

It's ok to use AI to help write the docs, but we need to make sure that we don't leave any hallucinations in it.

Thank you for the review. I use AI for reviewing English language and it appears there was a confusion between the table.options and the table APIs, leading to some auto-corrections in the code. My Bad.

@KevinVandy KevinVandy merged commit 6b4d616 into TanStack:main Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants