Skip to content

Commit 580d189

Browse files
committed
keep explicit group visibility entry in sync on toggle
1 parent 98037e0 commit 580d189

2 files changed

Lines changed: 53 additions & 3 deletions

File tree

‎packages/table-core/src/features/column-visibility/columnVisibilityFeature.utils.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ export function column_toggleVisibility<
6161
next[leafColumn.id] = nextVisible
6262
}
6363
}
64+
next[column.id] = nextVisible
6465

6566
return next
6667
})

‎packages/table-core/tests/unit/features/column-visibility/columnVisibilityFeature.utils.test.ts‎

Lines changed: 52 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,57 @@ describe('columnVisibilityFeature.utils', () => {
224224
column_toggleVisibility(groupColumn, false)
225225

226226
const result = getUpdaterResult(onColumnVisibilityChange, {})
227-
expect(result).toEqual({ firstName: false })
228-
expect(result).not.toHaveProperty('name')
227+
expect(result).toEqual({ firstName: false, name: false })
228+
})
229+
230+
it('should update an explicit parent entry when toggling a group column', () => {
231+
const onColumnVisibilityChange = vi.fn()
232+
const columns: Array<ColumnDef<typeof features, Person, any>> = [
233+
{
234+
id: 'name',
235+
columns: [
236+
{ accessorKey: 'firstName', id: 'firstName' },
237+
{ accessorKey: 'lastName', id: 'lastName' },
238+
],
239+
},
240+
]
241+
const table = constructTable({
242+
features,
243+
data: generateTestData(1),
244+
columns,
245+
onColumnVisibilityChange,
246+
initialState: {
247+
columnVisibility: { name: true, firstName: false, lastName: false },
248+
},
249+
})
250+
const groupColumn = table.getColumn('name')!
251+
252+
column_toggleVisibility(groupColumn, false)
253+
254+
let result = getUpdaterResult(onColumnVisibilityChange, {
255+
name: true,
256+
firstName: false,
257+
lastName: false,
258+
})
259+
expect(result).toEqual({
260+
name: false,
261+
firstName: false,
262+
lastName: false,
263+
})
264+
265+
onColumnVisibilityChange.mockClear()
266+
column_toggleVisibility(groupColumn, true)
267+
268+
result = getUpdaterResult(onColumnVisibilityChange, {
269+
name: false,
270+
firstName: false,
271+
lastName: false,
272+
})
273+
expect(result).toEqual({
274+
name: true,
275+
firstName: true,
276+
lastName: true,
277+
})
229278
})
230279

231280
it('should infer group visibility toggles from its leaf columns', () => {
@@ -250,7 +299,7 @@ describe('columnVisibilityFeature.utils', () => {
250299
column_toggleVisibility(groupColumn)
251300

252301
const result = getUpdaterResult(onColumnVisibilityChange, {})
253-
expect(result).toEqual({ firstName: false, lastName: false })
302+
expect(result).toEqual({ firstName: false, lastName: false, name: false })
254303
})
255304

256305
it('should not toggle when column cannot be hidden', () => {

0 commit comments

Comments
 (0)