fix(router-core): skip URL parsing for safe 'to' props by Sheraff · Pull Request #6442 · TanStack/router

Sheraff · 2026-01-21T19:12:04Z

If a to prop starts with / but not // it can be safely considered a relative path to be handled by the router and we don't need to go through the full new URL parsing.

Summary by CodeRabbit

Bug Fixes
- Improved handling of internal route navigation by optimizing link validation logic, enhancing performance for internal routes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-21T19:12:28Z

📝 Walkthrough

Walkthrough

A fast-path optimization was added to useLinkProps in the link handling logic. When the to prop is an internal, root-relative path (starts with single /), external URL validation is short-circuited by returning undefined for externalLink. This avoids unnecessary protocol and URL safety checks for internal routes.

Changes

Cohort / File(s)	Summary
Link validation optimization `packages/react-router/src/link.tsx`	Added fast-path check in `useLinkProps`: when `to` is an internal root-relative path (string starting with `/` but not `//`), skip external link validation to prevent false positives and improve performance

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

🐰 A swift path for links we've found,
When slashes mark internal ground,
No need for validation's heavy scan,
Just hop along—we've got a plan! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: skipping URL parsing for safe 'to' props (internal paths) to avoid unnecessary validation overhead.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-01-21T19:12:57Z

View your CI Pipeline Execution ↗ for commit aed91c6

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	11m 53s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	58s	View ↗

☁️ Nx Cloud last updated this comment at 2026-01-21 19:25:31 UTC

pkg-pr-new · 2026-01-21T19:15:14Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6442

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6442

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6442

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6442

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6442

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6442

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6442

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6442

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6442

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6442

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6442

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6442

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6442

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6442

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6442

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6442

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6442

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6442

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6442

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6442

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6442

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6442

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6442

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6442

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6442

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6442

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-fn-stubs@6442

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6442

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6442

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6442

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6442

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6442

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6442

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@6442

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@6442

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@6442

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@6442

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@6442

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@6442

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6442

commit: aed91c6

fix(router-core): skip URL parsing for safe 'to' props

aed91c6

github-actions Bot added the package: react-router label Jan 21, 2026

Sheraff merged commit 068f0d1 into main Jan 21, 2026
6 checks passed

Sheraff deleted the fix-router-core-skip-url-parsing-for-safe-internal-to branch January 21, 2026 19:26

coderabbitai Bot mentioned this pull request Jan 21, 2026

refactor(router-core): skip URL constructor in buildLocation #6447

Merged

Sheraff mentioned this pull request Jan 22, 2026

fix(solid-router): skip URL parsing for safe 'to' props #6453

Merged

This was referenced Jan 24, 2026

refactor: react link ssr perf #6482

Merged

feat(router-core, react-router, solid-router, vue-router): isDangerousProtocol uses customizable allowlist #6542

Merged

Navigation Menu

Repository navigation

fix(router-core): skip URL parsing for safe 'to' props - #6442

fix(router-core): skip URL parsing for safe 'to' props#6442
Sheraff merged 1 commit into
mainfrom
fix-router-core-skip-url-parsing-for-safe-internal-to

Sheraff commented Jan 21, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jan 21, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud Bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jan 21, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Sheraff commented Jan 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud Bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Jan 21, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sheraff commented Jan 21, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jan 21, 2026 •

edited

Loading

nx-cloud Bot commented Jan 21, 2026 •

edited

Loading