feat: provide location in onEnter/onStay/onLeave hooks#3622
Closed
jprosevear wants to merge 4 commits into
Closed
Conversation
Contributor
|
View your CI Pipeline Execution ↗ for commit 406cec6.
☁️ Nx Cloud last updated this comment at |
jprosevear
commented
Mar 1, 2025
More templates
@tanstack/arktype-adapter
@tanstack/create-router
@tanstack/create-start
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-api-routes
@tanstack/react-start-client
@tanstack/react-start-config
@tanstack/react-start-plugin
@tanstack/react-start-router-manifest
@tanstack/react-start-server
@tanstack/react-start-server-functions-client
@tanstack/react-start-server-functions-fetcher
@tanstack/react-start-server-functions-handler
@tanstack/react-start-server-functions-ssr
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-start
@tanstack/solid-start-api-routes
@tanstack/solid-start-client
@tanstack/solid-start-config
@tanstack/solid-start-plugin
@tanstack/solid-start-router-manifest
@tanstack/solid-start-server
@tanstack/solid-start-server-functions-client
@tanstack/solid-start-server-functions-fetcher
@tanstack/solid-start-server-functions-handler
@tanstack/solid-start-server-functions-ssr
@tanstack/start
@tanstack/start-config
@tanstack/start-server-functions-server
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
jprosevear
force-pushed
the
feat/location-in-hooks
branch
2 times, most recently
from
March 1, 2025 19:20
a0d83cb to
e6aef99
Compare
jprosevear
force-pushed
the
feat/location-in-hooks
branch
from
March 1, 2025 19:47
017c52c to
e0dae9b
Compare
Collaborator
There was a problem hiding this comment.
rather should have location defined in onEnter?
please also add a test for onStay and onLeave
Collaborator
There was a problem hiding this comment.
also applies to react-router of course
Contributor
Author
There was a problem hiding this comment.
Was just copying the style from above
Contributor
Author
There was a problem hiding this comment.
its in an onEnter describe block
Collaborator
There was a problem hiding this comment.
we should be able to supply the search type here (same for the others as well)
probably makes sense to create a type OnMatchOptions<TSearch> = {location:ParsedLocation<TSearch>
and use this for all 3 methods?
Contributor
Author
There was a problem hiding this comment.
i think this additional typing is a little out of my immediate grasp - can you give some more guidance
Collaborator
There was a problem hiding this comment.
before we do that, what is the semantic of location in each of these hooks?
I think in case of onLeave location is anything BUT the match, so we cannot statically type the search here.
whereas for the other hooks, the route's search is present in location
Contributor
Author
There was a problem hiding this comment.
Its the location that will resolve (assuming nothing thrown) - played with current / next like the useBlocker stuff but decided on this approach.
schiller-manuel
force-pushed
the
feat/location-in-hooks
branch
from
March 4, 2025 21:00
9d71302 to
e285bbe
Compare
wrong but as a starting point
schiller-manuel
force-pushed
the
feat/location-in-hooks
branch
from
March 4, 2025 21:04
768968a to
879b53b
Compare
Contributor
Author
|
@schiller-manuel how do you want to reconcile this? |
Member
|
Thanks for the PR. I'm closing it because it has fallen behind main (sorry it got lost in the shuffle), and the lifecycle implementation has since moved into router-core. The feature is still useful, so we’ve opened #7778 to track a fresh implementation. A new PR based on that issue would be welcome if you are still interested! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/719702312431386674/1345441363831033960