test(react-router) should update title on navigation #3610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit eeb77d4.
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/create-router
@tanstack/create-start
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-with-query
@tanstack/react-start-api-routes
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-config
@tanstack/react-start-plugin
@tanstack/react-start-router-manifest
@tanstack/react-start-server
@tanstack/react-start-server-functions-client
@tanstack/react-start-server-functions-fetcher
@tanstack/react-start-server-functions-handler
@tanstack/react-start-server-functions-ssr
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-start
@tanstack/solid-start-api-routes
@tanstack/solid-start-client
@tanstack/solid-start-config
@tanstack/solid-start-plugin
@tanstack/solid-start-router-manifest
@tanstack/solid-start-server
@tanstack/solid-start-server-functions-client
@tanstack/solid-start-server-functions-fetcher
@tanstack/solid-start-server-functions-handler
@tanstack/solid-start-server-functions-ssr
@tanstack/start
@tanstack/start-config
@tanstack/start-server-functions-server
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
birkskyum
changed the title
birkskyum
changed the title
birkskyum
changed the title
schiller-manuel
pushed a commit
that referenced
this pull request
Mar 1, 2025
Picking solid-router relevant changes from [commit](9eaa09e) by @brenelz , that fixes assets handler in solid-router by using `@solidjs/meta`. With this, the head tags like the title will update on client navigation. The changes in this PR that affect most files are merely repetitions of: - bumping solid 1.9.4 -> 1.9.5 - inserting `<HeadContent>` in the root route - removing `<title>` from the index.html Includes an automated test for solid-router corresponding to - #3610 --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
leesb971204
pushed a commit
to leesb971204/router
that referenced
this pull request
Apr 16, 2025
…ack#3616) Picking solid-router relevant changes from [commit](TanStack@9eaa09e) by @brenelz , that fixes assets handler in solid-router by using `@solidjs/meta`. With this, the head tags like the title will update on client navigation. The changes in this PR that affect most files are merely repetitions of: - bumping solid 1.9.4 -> 1.9.5 - inserting `<HeadContent>` in the root route - removing `<title>` from the index.html Includes an automated test for solid-router corresponding to - TanStack#3610 --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
leesb971204
pushed a commit
to leesb971204/router
that referenced
this pull request
Apr 16, 2025
when client navigating, the react-router doesn't update the head meta tags, such as the title --------- Co-authored-by: Manuel Schiller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when client navigating, the react-router doesn't update the head meta tags, such as the title