Skip to content

fix(solid-router): properly load components on lazy routes #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schiller-manuel merged 1 commit into from
Feb 27, 2025
Merged

fix(solid-router): properly load components on lazy routes #3589

schiller-manuel merged 1 commit into from
Feb 27, 2025

Conversation

@XiNiHa
Copy link
Contributor

@XiNiHa XiNiHa commented Feb 27, 2025

This fixes lazy routes on Solid Router, by waiting for loading the component using createResource() instead of throwing a promise.

@nx-cloud
Copy link

nx-cloud bot commented Feb 27, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9b71538.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 3m 34s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-27 13:15:18 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 27, 2025

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3589

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3589

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3589

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3589

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3589

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3589

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3589

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3589

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@3589

@tanstack/react-start-api-routes

npm i https://pkg.pr.new/@tanstack/react-start-api-routes@3589

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@3589

@tanstack/react-start-config

npm i https://pkg.pr.new/@tanstack/react-start-config@3589

@tanstack/react-start-plugin

npm i https://pkg.pr.new/@tanstack/react-start-plugin@3589

@tanstack/react-start-router-manifest

npm i https://pkg.pr.new/@tanstack/react-start-router-manifest@3589

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@3589

@tanstack/react-start-server-functions-client

npm i https://pkg.pr.new/@tanstack/react-start-server-functions-client@3589

@tanstack/react-start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/react-start-server-functions-fetcher@3589

@tanstack/react-start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/react-start-server-functions-handler@3589

@tanstack/react-start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/react-start-server-functions-ssr@3589

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3589

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3589

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3589

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3589

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3589

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3589

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@3589

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3589

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@3589

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3589

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3589

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3589

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3589

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3589

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3589

commit: 9b71538

@schiller-manuel schiller-manuel merged commit e1b5f07 into TanStack:main Feb 27, 2025
7 checks passed
@birkskyum birkskyum mentioned this pull request Feb 27, 2025
Merged
10 tasks
@XiNiHa XiNiHa deleted the fix-solid-lazy branch February 27, 2025 15:24
schiller-manuel pushed a commit that referenced this pull request Mar 1, 2025
@birkskyum @autofix-ci
@brenelz @XiNiHa
SolidJS driver for TanStack Start (#3522)
e2ac863 
This PR introduce support for Solid to be used with TanStack Start.

There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.

### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration

### Ongoing refactors

Refactor to make router packages (aka. client-only features) more
agnostic:
- #3552
- #3540
- #3538
- #3171

Refactor to make start packages (aka. server features) more agnostic:
- #3546 
- #3563 
- #3565 

### Upstream changes to solid-router
- #3592
- #3591
- #3589
- #3616 

### Passing E2E test suites
- [x]  basic
- [x]  website
- [x] scroll-restoration
- [x] server-functions

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <[email protected]>
Co-authored-by: Iha Shin <[email protected]>
Co-authored-by: Brenley Dueck <[email protected]>
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
@XiNiHa @leesb971204
fix(solid-router): properly load components on lazy routes (TanStack#…
6624213 
…3589)

This fixes lazy routes on Solid Router, by waiting for loading the
component using `createResource()` instead of throwing a promise.
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
@birkskyum @autofix-ci
@brenelz @XiNiHa @leesb971204
SolidJS driver for TanStack Start (TanStack#3522)
90f49de 
This PR introduce support for Solid to be used with TanStack Start.

There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.

### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration

### Ongoing refactors

Refactor to make router packages (aka. client-only features) more
agnostic:
- TanStack#3552
- TanStack#3540
- TanStack#3538
- TanStack#3171

Refactor to make start packages (aka. server features) more agnostic:
- TanStack#3546 
- TanStack#3563 
- TanStack#3565 

### Upstream changes to solid-router
- TanStack#3592
- TanStack#3591
- TanStack#3589
- TanStack#3616 

### Passing E2E test suites
- [x]  basic
- [x]  website
- [x] scroll-restoration
- [x] server-functions

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <[email protected]>
Co-authored-by: Iha Shin <[email protected]>
Co-authored-by: Brenley Dueck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: solid-router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XiNiHa @schiller-manuel