Skip to content

refactor(react-start): move start packages to react-start #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schiller-manuel merged 23 commits into from
Feb 25, 2025
Merged

refactor(react-start): move start packages to react-start #3563

schiller-manuel merged 23 commits into from
Feb 25, 2025

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Feb 25, 2025 •
edited
Loading

move start -> react-start, and keep start as proxy packages for backwards compat.

@nx-cloud
Copy link

nx-cloud bot commented Feb 25, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ba5762f.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 5m View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-25 20:58:00 UTC

@birkskyum birkskyum marked this pull request as draft February 25, 2025 17:58
@birkskyum birkskyum force-pushed the start-to-react-start branch from da866a5 to 559aa02 Compare February 25, 2025 18:05
@birkskyum birkskyum marked this pull request as ready for review February 25, 2025 18:27
@birkskyum
Copy link
Member Author

birkskyum commented Feb 25, 2025 •
edited
Loading

@schiller-manuel , would it technically be okay to only keep one @tanstack/start proxy package, and not have the other @tanstack/start-x packages but only keep the react-start-x?

@birkskyum
Copy link
Member Author

birkskyum commented Feb 25, 2025 •
edited
Loading

This PR is ready now.

@tanstack/start and @tanstack/start-config exist as duplicates of @tanstack/react-start and @tanstack/react-start-config to ensure backwards compatibility, and to guide users to migrate towards @tanstack/react-start in the console

The e2e tests are updated to use the new @tanstack/react-start
The examples use the @tanstack/start still, because they use published packages, so that'll have to be updated later.

@birkskyum birkskyum mentioned this pull request Feb 25, 2025
Merged
10 tasks
@SeanCassiere
Copy link
Member

SeanCassiere commented Feb 25, 2025

I don't mind breaking the existing @tanstack/start package in general, in favour of moving to @tanstack/react-start. The @tanstack/start package could be entirely emptied out and just containing console.error('[@tanstack/start]: This package has moved to "@tanstack/react-start". Uninstall and installation steps over here').

But I think you'd have to help @tannerlinsley in correctly having these changes pulled into and fixed up in the https://github.com/TanStack/router/tree/devinxi branch.

@birkskyum
Copy link
Member Author

birkskyum commented Feb 25, 2025 •
edited
Loading

@SeanCassiere , okay, I've removed the backwards compat package, so now this is a breaking PR, but the devinxi pr is too

EDIT the @tanstack/start-config is still there

@birkskyum birkskyum force-pushed the start-to-react-start branch from d896875 to a930231 Compare February 25, 2025 20:39
schiller-manuel
schiller-manuel reviewed Feb 25, 2025
View reviewed changes
schiller-manuel
schiller-manuel reviewed Feb 25, 2025
View reviewed changes
@schiller-manuel schiller-manuel merged commit 0cf5e3e into TanStack:main Feb 25, 2025
5 of 6 checks passed
@birkskyum birkskyum mentioned this pull request Feb 25, 2025
Merged
schiller-manuel pushed a commit that referenced this pull request Mar 1, 2025
@birkskyum @autofix-ci
@brenelz @XiNiHa
SolidJS driver for TanStack Start (#3522)
e2ac863 
This PR introduce support for Solid to be used with TanStack Start.

There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.

### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration

### Ongoing refactors

Refactor to make router packages (aka. client-only features) more
agnostic:
- #3552
- #3540
- #3538
- #3171

Refactor to make start packages (aka. server features) more agnostic:
- #3546 
- #3563 
- #3565 

### Upstream changes to solid-router
- #3592
- #3591
- #3589
- #3616 

### Passing E2E test suites
- [x]  basic
- [x]  website
- [x] scroll-restoration
- [x] server-functions

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <[email protected]>
Co-authored-by: Iha Shin <[email protected]>
Co-authored-by: Brenley Dueck <[email protected]>
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
@birkskyum @autofix-ci @leesb971204
refactor(react-start): move start packages to react-start (TanStack#3563
94190c0 
)

move start -> react-start, and keep start as proxy packages for
backwards compat.

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
@birkskyum @autofix-ci
@brenelz @XiNiHa @leesb971204
SolidJS driver for TanStack Start (TanStack#3522)
90f49de 
This PR introduce support for Solid to be used with TanStack Start.

There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.

### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration

### Ongoing refactors

Refactor to make router packages (aka. client-only features) more
agnostic:
- TanStack#3552
- TanStack#3540
- TanStack#3538
- TanStack#3171

Refactor to make start packages (aka. server features) more agnostic:
- TanStack#3546 
- TanStack#3563 
- TanStack#3565 

### Upstream changes to solid-router
- TanStack#3592
- TanStack#3591
- TanStack#3589
- TanStack#3616 

### Passing E2E test suites
- [x]  basic
- [x]  website
- [x] scroll-restoration
- [x] server-functions

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <[email protected]>
Co-authored-by: Iha Shin <[email protected]>
Co-authored-by: Brenley Dueck <[email protected]>
serhalp added a commit to netlify/build that referenced this pull request Apr 25, 2025
@serhalp
fix: detect new TanStack Start package names
b131c64 
See TanStack/router#3563 and TanStack/router#3522
@serhalp serhalp mentioned this pull request Apr 25, 2025
Merged
serhalp added a commit to netlify/build that referenced this pull request Apr 25, 2025
@serhalp
fix: detect new TanStack Start package names (#6212)
937a981 
See TanStack/router#3563 and TanStack/router#3522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schiller-manuel schiller-manuel schiller-manuel left review comments

Assignees

No one assigned

Labels

package: start-server-functions-server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@birkskyum @SeanCassiere @schiller-manuel