Skip to content

feat(react-router): implement standard schema into router core #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chorobin merged 7 commits into from
Oct 21, 2024
Merged

feat(react-router): implement standard schema into router core #2602

chorobin merged 7 commits into from
Oct 21, 2024

Conversation

@chorobin
Copy link
Contributor

@chorobin chorobin commented Oct 20, 2024

This PR implements Standard Schema in router core. Currently only valibot implements this but the intention is for all validation libraries to implement it. Which means we don't need to support adapters

@nx-cloud
Copy link

nx-cloud bot commented Oct 20, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9244d99. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@chorobin
Copy link
Contributor Author

chorobin commented Oct 20, 2024

  • Update docs
  • Type tests

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 20, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2602

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2602

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2602

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2602

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2602

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2602

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2602

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2602

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2602

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2602

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2602

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2602

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2602

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2602

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2602

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2602

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2602

commit: 9244d99

@chorobin chorobin marked this pull request as ready for review October 20, 2024 23:02
@chorobin chorobin force-pushed the standard-schema branch 2 times, most recently from 81b0cfc to 395cdc6 Compare October 21, 2024 20:35
@schiller-manuel schiller-manuel changed the title feat: implement standard schema into router core feat(react-router): implement standard schema into router core Oct 21, 2024
@chorobin chorobin merged commit 5d62c03 into main Oct 21, 2024
@chorobin chorobin deleted the standard-schema branch October 21, 2024 21:23
@Balastrong Balastrong mentioned this pull request Nov 12, 2024
Closed
@AlexErrant AlexErrant mentioned this pull request Mar 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chorobin