You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
preload: undefined context in loader if navigation happens before beforeLoad is done #1886
Supposing /about is the lazy route that takes a long time to resolve, if beforeLoad isn't finished before the navigation event happens, the loader gets invoked with an undefined context, breaking the route.
This possibly happens because execution flow is skipped when a route already in beforeLoad fetching state is re-loaded (because the loader gets invoked regardless of the beforeLoad state, for which we have no pending information on reload)
Activity
schiller-manuel commentedon Jul 6, 2024
this will be fixed by #1907
reproducer with pre-release package: https://stackblitz.com/edit/github-nkiyw7-ojt8yk?file=src%2Froutes%2Fabout.tsx
freshgiammi commentedon Jul 6, 2024
I guess I can close #1891 then?
schiller-manuel commentedon Jul 6, 2024
yes we'll close #1891, but I will take over the test from there, so thanks for implementing that!