Skip to content

Commit f2a4666

Browse files
committed
make e2e dev-only
1 parent 6380e00 commit f2a4666

2 files changed

Lines changed: 4 additions & 9 deletions

File tree

‎e2e/solid-start/nitro-query/package.json‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66
"scripts": {
77
"dev": "vite dev --port 3000",
88
"dev:e2e": "vite dev",
9-
"build": "vite build && tsc --noEmit",
10-
"preview": "vite preview",
11-
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
129
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
1310
},
1411
"dependencies": {

‎e2e/solid-start/nitro-query/playwright.config.ts‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,16 @@ import packageJson from './package.json' with { type: 'json' }
55
const PORT = await getTestServerPort(packageJson.name)
66
const baseURL = `http://localhost:${PORT}`
77

8-
const mode = process.env.MODE ?? 'dev'
9-
const isDev = mode === 'dev'
10-
8+
// #6151 only reproduces in dev — `@tanstack/solid-query` ships separate
9+
// development/production builds. Production builds use a single file, so the
10+
// dual-context bug can't manifest. This e2e is dev-only.
1111
export default defineConfig({
1212
testDir: './tests',
1313
workers: 1,
1414
reporter: [['line']],
1515
use: { baseURL },
1616
webServer: {
17-
command: isDev
18-
? `PORT=${PORT} pnpm dev:e2e`
19-
: `pnpm build && PORT=${PORT} pnpm start`,
17+
command: `PORT=${PORT} pnpm dev:e2e`,
2018
url: baseURL,
2119
reuseExistingServer: !process.env.CI,
2220
stdout: 'pipe',

0 commit comments

Comments
 (0)