Skip to content

Commit d7445e0

Browse files
fix: better react HMR (#7005)
* fix: better react HMR * layout and fixes * fix * stabilize test * stabilize test
1 parent 0d11d5e commit d7445e0

39 files changed

Lines changed: 2745 additions & 229 deletions

‎e2e/react-start/hmr/package.json‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,12 @@
1717
},
1818
"devDependencies": {
1919
"@playwright/test": "^1.50.1",
20+
"@tailwindcss/vite": "^4.2.2",
2021
"@tanstack/router-e2e-utils": "workspace:^",
2122
"@types/node": "^22.10.2",
2223
"@types/react": "^19.0.8",
2324
"@types/react-dom": "^19.0.3",
25+
"tailwindcss": "^4.2.2",
2426
"@vitejs/plugin-react": "^6.0.1",
2527
"typescript": "^5.7.2",
2628
"vite": "^8.0.0"

‎e2e/react-start/hmr/src/routeTree.gen.ts‎

Lines changed: 200 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,66 @@
99
// Additionally, you should also exclude this file from your linter and/or formatter to prevent it from being checked or modified.
1010

1111
import { Route as rootRouteImport } from './routes/__root'
12+
import { Route as InputsRouteImport } from './routes/inputs'
13+
import { Route as ComponentHmrNamedSplitRouteImport } from './routes/component-hmr-named-split'
14+
import { Route as ComponentHmrNamedNosplitRouteImport } from './routes/component-hmr-named-nosplit'
15+
import { Route as ComponentHmrNamedErrorSplitRouteImport } from './routes/component-hmr-named-error-split'
16+
import { Route as ComponentHmrInlineSplitRouteImport } from './routes/component-hmr-inline-split'
17+
import { Route as ComponentHmrInlineNosplitRouteImport } from './routes/component-hmr-inline-nosplit'
18+
import { Route as ComponentHmrInlineErrorSplitRouteImport } from './routes/component-hmr-inline-error-split'
19+
import { Route as ComponentHmrRouteImport } from './routes/component-hmr'
20+
import { Route as ChildRouteImport } from './routes/child'
1221
import { Route as IndexRouteImport } from './routes/index'
1322

23+
const InputsRoute = InputsRouteImport.update({
24+
id: '/inputs',
25+
path: '/inputs',
26+
getParentRoute: () => rootRouteImport,
27+
} as any)
28+
const ComponentHmrNamedSplitRoute = ComponentHmrNamedSplitRouteImport.update({
29+
id: '/component-hmr-named-split',
30+
path: '/component-hmr-named-split',
31+
getParentRoute: () => rootRouteImport,
32+
} as any)
33+
const ComponentHmrNamedNosplitRoute =
34+
ComponentHmrNamedNosplitRouteImport.update({
35+
id: '/component-hmr-named-nosplit',
36+
path: '/component-hmr-named-nosplit',
37+
getParentRoute: () => rootRouteImport,
38+
} as any)
39+
const ComponentHmrNamedErrorSplitRoute =
40+
ComponentHmrNamedErrorSplitRouteImport.update({
41+
id: '/component-hmr-named-error-split',
42+
path: '/component-hmr-named-error-split',
43+
getParentRoute: () => rootRouteImport,
44+
} as any)
45+
const ComponentHmrInlineSplitRoute = ComponentHmrInlineSplitRouteImport.update({
46+
id: '/component-hmr-inline-split',
47+
path: '/component-hmr-inline-split',
48+
getParentRoute: () => rootRouteImport,
49+
} as any)
50+
const ComponentHmrInlineNosplitRoute =
51+
ComponentHmrInlineNosplitRouteImport.update({
52+
id: '/component-hmr-inline-nosplit',
53+
path: '/component-hmr-inline-nosplit',
54+
getParentRoute: () => rootRouteImport,
55+
} as any)
56+
const ComponentHmrInlineErrorSplitRoute =
57+
ComponentHmrInlineErrorSplitRouteImport.update({
58+
id: '/component-hmr-inline-error-split',
59+
path: '/component-hmr-inline-error-split',
60+
getParentRoute: () => rootRouteImport,
61+
} as any)
62+
const ComponentHmrRoute = ComponentHmrRouteImport.update({
63+
id: '/component-hmr',
64+
path: '/component-hmr',
65+
getParentRoute: () => rootRouteImport,
66+
} as any)
67+
const ChildRoute = ChildRouteImport.update({
68+
id: '/child',
69+
path: '/child',
70+
getParentRoute: () => rootRouteImport,
71+
} as any)
1472
const IndexRoute = IndexRouteImport.update({
1573
id: '/',
1674
path: '/',
@@ -19,28 +77,158 @@ const IndexRoute = IndexRouteImport.update({
1977

2078
export interface FileRoutesByFullPath {
2179
'/': typeof IndexRoute
80+
'/child': typeof ChildRoute
81+
'/component-hmr': typeof ComponentHmrRoute
82+
'/component-hmr-inline-error-split': typeof ComponentHmrInlineErrorSplitRoute
83+
'/component-hmr-inline-nosplit': typeof ComponentHmrInlineNosplitRoute
84+
'/component-hmr-inline-split': typeof ComponentHmrInlineSplitRoute
85+
'/component-hmr-named-error-split': typeof ComponentHmrNamedErrorSplitRoute
86+
'/component-hmr-named-nosplit': typeof ComponentHmrNamedNosplitRoute
87+
'/component-hmr-named-split': typeof ComponentHmrNamedSplitRoute
88+
'/inputs': typeof InputsRoute
2289
}
2390
export interface FileRoutesByTo {
2491
'/': typeof IndexRoute
92+
'/child': typeof ChildRoute
93+
'/component-hmr': typeof ComponentHmrRoute
94+
'/component-hmr-inline-error-split': typeof ComponentHmrInlineErrorSplitRoute
95+
'/component-hmr-inline-nosplit': typeof ComponentHmrInlineNosplitRoute
96+
'/component-hmr-inline-split': typeof ComponentHmrInlineSplitRoute
97+
'/component-hmr-named-error-split': typeof ComponentHmrNamedErrorSplitRoute
98+
'/component-hmr-named-nosplit': typeof ComponentHmrNamedNosplitRoute
99+
'/component-hmr-named-split': typeof ComponentHmrNamedSplitRoute
100+
'/inputs': typeof InputsRoute
25101
}
26102
export interface FileRoutesById {
27103
__root__: typeof rootRouteImport
28104
'/': typeof IndexRoute
105+
'/child': typeof ChildRoute
106+
'/component-hmr': typeof ComponentHmrRoute
107+
'/component-hmr-inline-error-split': typeof ComponentHmrInlineErrorSplitRoute
108+
'/component-hmr-inline-nosplit': typeof ComponentHmrInlineNosplitRoute
109+
'/component-hmr-inline-split': typeof ComponentHmrInlineSplitRoute
110+
'/component-hmr-named-error-split': typeof ComponentHmrNamedErrorSplitRoute
111+
'/component-hmr-named-nosplit': typeof ComponentHmrNamedNosplitRoute
112+
'/component-hmr-named-split': typeof ComponentHmrNamedSplitRoute
113+
'/inputs': typeof InputsRoute
29114
}
30115
export interface FileRouteTypes {
31116
fileRoutesByFullPath: FileRoutesByFullPath
32-
fullPaths: '/'
117+
fullPaths:
118+
| '/'
119+
| '/child'
120+
| '/component-hmr'
121+
| '/component-hmr-inline-error-split'
122+
| '/component-hmr-inline-nosplit'
123+
| '/component-hmr-inline-split'
124+
| '/component-hmr-named-error-split'
125+
| '/component-hmr-named-nosplit'
126+
| '/component-hmr-named-split'
127+
| '/inputs'
33128
fileRoutesByTo: FileRoutesByTo
34-
to: '/'
35-
id: '__root__' | '/'
129+
to:
130+
| '/'
131+
| '/child'
132+
| '/component-hmr'
133+
| '/component-hmr-inline-error-split'
134+
| '/component-hmr-inline-nosplit'
135+
| '/component-hmr-inline-split'
136+
| '/component-hmr-named-error-split'
137+
| '/component-hmr-named-nosplit'
138+
| '/component-hmr-named-split'
139+
| '/inputs'
140+
id:
141+
| '__root__'
142+
| '/'
143+
| '/child'
144+
| '/component-hmr'
145+
| '/component-hmr-inline-error-split'
146+
| '/component-hmr-inline-nosplit'
147+
| '/component-hmr-inline-split'
148+
| '/component-hmr-named-error-split'
149+
| '/component-hmr-named-nosplit'
150+
| '/component-hmr-named-split'
151+
| '/inputs'
36152
fileRoutesById: FileRoutesById
37153
}
38154
export interface RootRouteChildren {
39155
IndexRoute: typeof IndexRoute
156+
ChildRoute: typeof ChildRoute
157+
ComponentHmrRoute: typeof ComponentHmrRoute
158+
ComponentHmrInlineErrorSplitRoute: typeof ComponentHmrInlineErrorSplitRoute
159+
ComponentHmrInlineNosplitRoute: typeof ComponentHmrInlineNosplitRoute
160+
ComponentHmrInlineSplitRoute: typeof ComponentHmrInlineSplitRoute
161+
ComponentHmrNamedErrorSplitRoute: typeof ComponentHmrNamedErrorSplitRoute
162+
ComponentHmrNamedNosplitRoute: typeof ComponentHmrNamedNosplitRoute
163+
ComponentHmrNamedSplitRoute: typeof ComponentHmrNamedSplitRoute
164+
InputsRoute: typeof InputsRoute
40165
}
41166

42167
declare module '@tanstack/react-router' {
43168
interface FileRoutesByPath {
169+
'/inputs': {
170+
id: '/inputs'
171+
path: '/inputs'
172+
fullPath: '/inputs'
173+
preLoaderRoute: typeof InputsRouteImport
174+
parentRoute: typeof rootRouteImport
175+
}
176+
'/component-hmr-named-split': {
177+
id: '/component-hmr-named-split'
178+
path: '/component-hmr-named-split'
179+
fullPath: '/component-hmr-named-split'
180+
preLoaderRoute: typeof ComponentHmrNamedSplitRouteImport
181+
parentRoute: typeof rootRouteImport
182+
}
183+
'/component-hmr-named-nosplit': {
184+
id: '/component-hmr-named-nosplit'
185+
path: '/component-hmr-named-nosplit'
186+
fullPath: '/component-hmr-named-nosplit'
187+
preLoaderRoute: typeof ComponentHmrNamedNosplitRouteImport
188+
parentRoute: typeof rootRouteImport
189+
}
190+
'/component-hmr-named-error-split': {
191+
id: '/component-hmr-named-error-split'
192+
path: '/component-hmr-named-error-split'
193+
fullPath: '/component-hmr-named-error-split'
194+
preLoaderRoute: typeof ComponentHmrNamedErrorSplitRouteImport
195+
parentRoute: typeof rootRouteImport
196+
}
197+
'/component-hmr-inline-split': {
198+
id: '/component-hmr-inline-split'
199+
path: '/component-hmr-inline-split'
200+
fullPath: '/component-hmr-inline-split'
201+
preLoaderRoute: typeof ComponentHmrInlineSplitRouteImport
202+
parentRoute: typeof rootRouteImport
203+
}
204+
'/component-hmr-inline-nosplit': {
205+
id: '/component-hmr-inline-nosplit'
206+
path: '/component-hmr-inline-nosplit'
207+
fullPath: '/component-hmr-inline-nosplit'
208+
preLoaderRoute: typeof ComponentHmrInlineNosplitRouteImport
209+
parentRoute: typeof rootRouteImport
210+
}
211+
'/component-hmr-inline-error-split': {
212+
id: '/component-hmr-inline-error-split'
213+
path: '/component-hmr-inline-error-split'
214+
fullPath: '/component-hmr-inline-error-split'
215+
preLoaderRoute: typeof ComponentHmrInlineErrorSplitRouteImport
216+
parentRoute: typeof rootRouteImport
217+
}
218+
'/component-hmr': {
219+
id: '/component-hmr'
220+
path: '/component-hmr'
221+
fullPath: '/component-hmr'
222+
preLoaderRoute: typeof ComponentHmrRouteImport
223+
parentRoute: typeof rootRouteImport
224+
}
225+
'/child': {
226+
id: '/child'
227+
path: '/child'
228+
fullPath: '/child'
229+
preLoaderRoute: typeof ChildRouteImport
230+
parentRoute: typeof rootRouteImport
231+
}
44232
'/': {
45233
id: '/'
46234
path: '/'
@@ -53,6 +241,15 @@ declare module '@tanstack/react-router' {
53241

54242
const rootRouteChildren: RootRouteChildren = {
55243
IndexRoute: IndexRoute,
244+
ChildRoute: ChildRoute,
245+
ComponentHmrRoute: ComponentHmrRoute,
246+
ComponentHmrInlineErrorSplitRoute: ComponentHmrInlineErrorSplitRoute,
247+
ComponentHmrInlineNosplitRoute: ComponentHmrInlineNosplitRoute,
248+
ComponentHmrInlineSplitRoute: ComponentHmrInlineSplitRoute,
249+
ComponentHmrNamedErrorSplitRoute: ComponentHmrNamedErrorSplitRoute,
250+
ComponentHmrNamedNosplitRoute: ComponentHmrNamedNosplitRoute,
251+
ComponentHmrNamedSplitRoute: ComponentHmrNamedSplitRoute,
252+
InputsRoute: InputsRoute,
56253
}
57254
export const routeTree = rootRouteImport
58255
._addFileChildren(rootRouteChildren)

0 commit comments

Comments
 (0)