Skip to content

Commit d59b5be

Browse files
stabilize tests
1 parent 9af0d9d commit d59b5be

1 file changed

Lines changed: 2 additions & 28 deletions

File tree

‎e2e/react-start/import-protection/tests/import-protection.spec.ts‎

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -704,8 +704,8 @@ for (const mode of ['build', 'dev', 'dev.warm'] as const) {
704704
// never imports foo at all. Both the .server module and the marker module
705705
// should NOT survive tree-shaking in the client bundle, so import-protection
706706
// must NOT flag violations for either in build mode.
707-
// Dev behavior is adapter-dependent: Vite warns for this pattern, while Rsbuild
708-
// can either warn or elide it depending on dev transform/chunk graph ordering.
707+
// Dev behavior is not part of this contract because barrel re-export diagnostics
708+
// can warn or be elided depending on dev transform/chunk graph ordering.
709709

710710
test('barrel-false-positive route loads in mock mode', async ({ page }) => {
711711
await page.goto('/barrel-false-positive')
@@ -729,32 +729,6 @@ test('no false positive for barrel-reexport marker pattern in build', async () =
729729
expect(findBarrelMarkerHits(violations)).toEqual([])
730730
})
731731

732-
for (const mode of ['dev', 'dev.warm'] as const) {
733-
test(`barrel-reexport .server dev behavior matches ${toolchain} in ${mode}`, async () => {
734-
test.skip(
735-
toolchain !== 'vite',
736-
'Rsbuild dev barrel re-export false-positive reporting is not deterministic; build mode is the stable contract.',
737-
)
738-
739-
const violations = await readViolations(mode)
740-
const hits = findBarrelReexportHits(violations)
741-
742-
expect(hits.length).toBeGreaterThanOrEqual(1)
743-
})
744-
745-
test(`barrel-reexport marker dev behavior matches ${toolchain} in ${mode}`, async () => {
746-
test.skip(
747-
toolchain !== 'vite',
748-
'Rsbuild dev barrel re-export false-positive reporting is not deterministic; build mode is the stable contract.',
749-
)
750-
751-
const violations = await readViolations(mode)
752-
const hits = findBarrelMarkerHits(violations)
753-
754-
expect(hits.length).toBeGreaterThanOrEqual(1)
755-
})
756-
}
757-
758732
// noExternal .client package false positive: react-tweet's package.json
759733
// exports resolve to `index.client.js` via the "default" condition.
760734
// When listed in ssr.noExternal, Vite bundles it and the resolved path

0 commit comments

Comments
 (0)