You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d4284cb
Browse filesBrowse the repository at this point in the historyBrowse files
committed
fix(solid-router): name observe navigations by the route the pathname matches
The navigation declared to Solid's observe tier took its name and params
from the leaf expected match. A not-found's leaf is the route above it, so
every unmatched path was named after the root ('/') and folded into the
home page's feedback row; and the params were the values params.parse
returned, where NavigationRef declares the strings the path bound.
Name and params now come from matching the destination pathname
(router.getMatchedRoutes, the same rule matchRoutes uses for its 404
entry): the route's fullPath and its raw params, or the pathname itself
when no route matches it. The description moves to observe.ts so the
initial-route declaration can share it.
Co-authored-by: Claude <[email protected]>
Co-authored-by: Cursor <[email protected]>
Observe tier (Solid's dev and observe builds only): a navigation's record names a not-found by its pathname instead of the route above it, so `/nope` no longer files under `/` beside the home page, and its `params` are the strings the path bound rather than the values `params.parse` returned, as Solid's `NavigationRef` declares them. Nothing changes in production, where `OBSERVE` is undefined.
0 commit comments