Repository navigation
Commit c70a2ce
fix(solid-router): declare a not-found whose unloaded match stays pending
The Transitioner tells the pending offer (`offerPending`, published while
the loaders run) from the publish that lands by a match with
`status: 'pending'`. A not-found under a route with a loader lands with
that route's match pending too: it sits below the not-found boundary and
never loads. So the landing publish was taken for the offer, published
undeclared, and the navigation had no record. Solid Router records an
unmatched path under a route with data like any other, named by its
pathname.
A publish is the offer only when a match at or above the not-found
boundary is pending. With a pending component, router-core offers the same
matches (pending below the boundary) before it lands; that offer already
shows the destination, the not-found rendering above the pending match,
so it is the publish declared and the landing that repeats it is not.
Co-authored-by: Claude <[email protected]>
Co-authored-by: Cursor <[email protected]>1 parent 0d78d79 commit c70a2ce
3 files changed
Lines changed: 55 additions & 8 deletions
File tree
- .changeset
- packages/solid-router
- src
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
12 | 26 | | |
13 | 27 | | |
14 | 28 | | |
| |||
60 | 74 | | |
61 | 75 | | |
62 | 76 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
70 | 81 | | |
71 | 82 | | |
72 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
42 | 46 | | |
43 | 47 | | |
44 | 48 | | |
| |||
105 | 109 | | |
106 | 110 | | |
107 | 111 | | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
108 | 116 | | |
109 | 117 | | |
110 | 118 | | |
| |||
332 | 340 | | |
333 | 341 | | |
334 | 342 | | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
335 | 366 | | |
336 | 367 | | |
337 | 368 | | |
| |||
0 commit comments