Skip to content

Commit bfaf6ab

Browse files
committed
fix(start): reject non-ok JSON server function responses
1 parent aee42c6 commit bfaf6ab

3 files changed

Lines changed: 40 additions & 0 deletions

File tree

‎.changeset/quiet-rivers-reject.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@tanstack/start-client-core': patch
3+
---
4+
5+
Reject non-OK JSON server function responses that were not serialized by TanStack Start.

‎packages/start-client-core/src/client-rpc/serverFnFetcher.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,9 @@ async function getResponse(fn: () => Promise<Response>) {
328328
if (isNotFound(jsonPayload)) {
329329
throw jsonPayload
330330
}
331+
if (!response.ok) {
332+
throw new Error(JSON.stringify(jsonPayload))
333+
}
331334
return jsonPayload
332335
}
333336

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
import { describe, expect, it, vi } from 'vitest'
2+
import { serverFnFetcher } from '../src/client-rpc/serverFnFetcher'
3+
4+
vi.mock('../src/getDefaultSerovalPlugins', () => ({
5+
getDefaultSerovalPlugins: () => [],
6+
}))
7+
8+
describe('serverFnFetcher', () => {
9+
it('rejects non-ok JSON responses that were not serialized by Start', async () => {
10+
const body = {
11+
status: 500,
12+
unhandled: true,
13+
message: 'HTTPError',
14+
}
15+
16+
const result = serverFnFetcher('/_serverFn/test', [{ method: 'GET' }], () =>
17+
Promise.resolve(Response.json(body, { status: 500 })),
18+
)
19+
20+
await expect(result).rejects.toThrow(JSON.stringify(body))
21+
})
22+
23+
it('returns ok JSON responses that were not serialized by Start', async () => {
24+
const body = { result: 'ok' }
25+
26+
const result = serverFnFetcher('/_serverFn/test', [{ method: 'GET' }], () =>
27+
Promise.resolve(Response.json(body)),
28+
)
29+
30+
await expect(result).resolves.toEqual(body)
31+
})
32+
})

0 commit comments

Comments
 (0)