Skip to content

Commit 9a524c6

Browse files
fix: filter out routes from manifest that have neither preloads nor assets
1 parent 2c90c0c commit 9a524c6

2 files changed

Lines changed: 22 additions & 7 deletions

File tree

‎packages/start-plugin-core/src/start-manifest-plugin/plugin.ts‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,16 @@ export function startManifestPlugin(opts: {
244244

245245
recurseRoute(routeTreeRoutes[rootRouteId]!)
246246

247+
// Filter out routes that have neither assets nor preloads
248+
Object.keys(routeTreeRoutes).forEach((routeId) => {
249+
const route = routeTreeRoutes[routeId]!
250+
const hasAssets = route.assets && route.assets.length > 0
251+
const hasPreloads = route.preloads && route.preloads.length > 0
252+
if (!hasAssets && !hasPreloads) {
253+
delete routeTreeRoutes[routeId]
254+
}
255+
})
256+
247257
const startManifest = {
248258
routes: routeTreeRoutes,
249259
clientEntry: joinURL(

‎packages/start-server-core/src/router-manifest.ts‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { rootRouteId } from '@tanstack/router-core'
22
import { VIRTUAL_MODULES } from './virtual-modules'
33
import { loadVirtualModule } from './loadVirtualModule'
4+
import type { RouterManagedTag } from '@tanstack/router-core'
45

56
/**
67
* @description Returns the router manifest that should be sent to the client.
@@ -43,13 +44,17 @@ export async function getStartManifest() {
4344
routes: Object.fromEntries(
4445
Object.entries(startManifest.routes).map(([k, v]) => {
4546
const { preloads, assets } = v
46-
return [
47-
k,
48-
{
49-
preloads,
50-
assets,
51-
},
52-
]
47+
const result = {} as {
48+
preloads?: Array<string>
49+
assets?: Array<RouterManagedTag>
50+
}
51+
if (preloads) {
52+
result['preloads'] = preloads
53+
}
54+
if (assets) {
55+
result['assets'] = assets
56+
}
57+
return [k, result]
5358
}),
5459
),
5560
}

0 commit comments

Comments
 (0)