Skip to content

Commit 6ea543e

Browse files
committed
fix(router): correct href generation for target=_blank links in hash history mode
Signed-off-by: leesb971204 <[email protected]>
1 parent 7771c00 commit 6ea543e

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎packages/react-router/src/link.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,13 +120,13 @@ export function useLinkProps<
120120
let external = false
121121
if (router.origin) {
122122
if (href.startsWith(router.origin)) {
123-
href = href.replace(router.origin, '') || '/'
123+
href = router.history.createHref(href.replace(router.origin, '')) || '/'
124124
} else {
125125
external = true
126126
}
127127
}
128128
return { href, external }
129-
}, [disabled, next.maskedLocation, next.url, router.origin])
129+
}, [disabled, next.maskedLocation, next.url, router.origin, router.history])
130130

131131
const externalLink = React.useMemo(() => {
132132
if (hrefOption?.external) {

‎packages/solid-router/src/link.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ export function useLinkProps<
146146
let external = false
147147
if (router.origin) {
148148
if (href.startsWith(router.origin)) {
149-
href = href.replace(router.origin, '')
149+
href = router.history.createHref(href.replace(router.origin, ''))
150150
} else {
151151
external = true
152152
}

0 commit comments

Comments
 (0)