Skip to content

Commit 21ec2d6

Browse files
refactor(e2e): replace createTrackedEffect mount probes with onSettled
The relative-routing render-count probes have no reactive reads; they are mount-scoped one-shots, which is onSettled's shape. createTrackedEffect is reserved for dynamic same-scope subscription patterns. Co-authored-by: Cursor <[email protected]>
1 parent 7b257e6 commit 21ec2d6

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎e2e/solid-router/basic-file-based/src/routes/relative/link/route.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {
44
createFileRoute,
55
useNavigate,
66
} from '@tanstack/solid-router'
7-
import { createTrackedEffect } from 'solid-js'
7+
import { onSettled } from 'solid-js'
88

99
export const Route = createFileRoute('/relative/link')({
1010
component: RouteComponent,
@@ -13,7 +13,7 @@ export const Route = createFileRoute('/relative/link')({
1313
function RouteComponent() {
1414
const navigate = useNavigate()
1515

16-
createTrackedEffect(() => {
16+
onSettled(() => {
1717
console.log('navigate')
1818
})
1919

‎e2e/solid-router/basic-file-based/src/routes/relative/useNavigate/route.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Outlet, createFileRoute, useNavigate } from '@tanstack/solid-router'
2-
import { createTrackedEffect } from 'solid-js'
2+
import { onSettled } from 'solid-js'
33

44
export const Route = createFileRoute('/relative/useNavigate')({
55
component: RouteComponent,
@@ -8,7 +8,7 @@ export const Route = createFileRoute('/relative/useNavigate')({
88
function RouteComponent() {
99
const navigate = useNavigate()
1010

11-
createTrackedEffect(() => {
11+
onSettled(() => {
1212
console.log('navigate')
1313
})
1414

0 commit comments

Comments
 (0)