Skip to content

Commit 1defaae

Browse files
test: add reproducer for #2514
already fixed on main
1 parent 15df770 commit 1defaae

1 file changed

Lines changed: 101 additions & 0 deletions

File tree

‎packages/react-router/tests/errorComponent.test.tsx‎

Lines changed: 101 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@ import { act, cleanup, fireEvent, render, screen } from '@testing-library/react'
33

44
import {
55
Link,
6+
Outlet,
67
RouterProvider,
78
createBrowserHistory,
89
createLazyRoute,
10+
createMemoryHistory,
911
createRootRoute,
1012
createRoute,
1113
createRouter,
14+
notFound,
1215
} from '../src'
1316
import type { ErrorComponentProps, RouterHistory } from '../src'
1417

@@ -258,3 +261,101 @@ describe.each([true, false])(
258261
})
259262
},
260263
)
264+
265+
describe('notFoundComponent is rendered when an error is thrown in params.parse', () => {
266+
test('displays notFoundComponent when error is thrown in params.parse', async () => {
267+
const history = createMemoryHistory({ initialEntries: ['/'] })
268+
const rootLoader = vi.fn(async () => {
269+
await new Promise((resolve) => setTimeout(resolve, 1))
270+
return { ok: true }
271+
})
272+
273+
const rootRoute = createRootRoute({
274+
component: function Root() {
275+
return <Outlet />
276+
},
277+
notFoundComponent: function NotFound() {
278+
return <div>No pizza</div>
279+
},
280+
pendingComponent: function Pending() {
281+
return <div>Loading...</div>
282+
},
283+
loader: rootLoader,
284+
shouldReload: true,
285+
pendingMs: 0,
286+
pendingMinMs: 100,
287+
wrapInSuspense: true,
288+
})
289+
290+
const indexRoute = createRoute({
291+
getParentRoute: () => rootRoute,
292+
path: '/',
293+
component: function Home() {
294+
return (
295+
<div>
296+
<Link to="/pizza/rotten" preload="intent">
297+
link to rotten pizza
298+
</Link>
299+
</div>
300+
)
301+
},
302+
})
303+
304+
const restaurantRoute = createRoute({
305+
getParentRoute: () => rootRoute,
306+
id: 'restaurant',
307+
component: function Restaurant() {
308+
return <Outlet />
309+
},
310+
})
311+
312+
const pizzaRoute = createRoute({
313+
getParentRoute: () => restaurantRoute,
314+
path: '/pizza/$pizzaType',
315+
component: function Pizza() {
316+
return <div>Pizza</div>
317+
},
318+
params: {
319+
parse: (p) => {
320+
if (p.pizzaType === 'rotten') {
321+
throw new Error('404 No rotten pizzas')
322+
}
323+
return { pizzaType: p.pizzaType }
324+
},
325+
stringify: (p) => ({ pizzaType: p.pizzaType }),
326+
},
327+
onError: () => {
328+
throw notFound()
329+
},
330+
})
331+
332+
const routeTree = rootRoute.addChildren([
333+
indexRoute,
334+
restaurantRoute.addChildren([pizzaRoute]),
335+
])
336+
337+
const router = createRouter({
338+
routeTree,
339+
history,
340+
})
341+
342+
render(<RouterProvider router={router} />)
343+
344+
await act(() => router.latestLoadPromise)
345+
expect(rootLoader).toHaveBeenCalledTimes(1)
346+
347+
const linkToRottenPizza = await screen.findByRole('link', {
348+
name: 'link to rotten pizza',
349+
})
350+
351+
expect(linkToRottenPizza).toBeInTheDocument()
352+
await act(() => fireEvent.mouseOver(linkToRottenPizza))
353+
await act(() => fireEvent.click(linkToRottenPizza))
354+
355+
const notFoundComponent = await screen.findByText('No pizza', undefined, {
356+
timeout: 750,
357+
})
358+
expect(rootLoader).toHaveBeenCalledTimes(2)
359+
expect(notFoundComponent).toBeInTheDocument()
360+
})
361+
})

0 commit comments

Comments
 (0)