Skip to content

Commit 0fa77f0

Browse files
committed
code rabbit nitpicks
1 parent 6d164b7 commit 0fa77f0

4 files changed

Lines changed: 12 additions & 8 deletions

File tree

‎e2e/react-router/basic-file-based/src/routes/non-nested/route.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ function RouteComponent() {
2020
>
2121
/non-nested/baz/123
2222
</Link>
23+
</li>
24+
<li>
2325
<Link
2426
from={Route.fullPath}
2527
data-testid="l-to-non-nested-bazid-edit"

‎e2e/react-router/basic-file-based/tests/app.spec.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -313,8 +313,8 @@ test('Should not nest non-nested paths', async ({ page }) => {
313313
await page.goto('/non-nested')
314314
await page.waitForURL('/non-nested')
315315
const nonNestedPathHeading = page.getByTestId('non-nested-path-heading')
316-
const bazIdLink = await page.getByTestId('l-to-non-nested-bazid')
317-
const bazIdEditLink = await page.getByTestId('l-to-non-nested-bazid-edit')
316+
const bazIdLink = page.getByTestId('l-to-non-nested-bazid')
317+
const bazIdEditLink = page.getByTestId('l-to-non-nested-bazid-edit')
318318

319319
await expect(nonNestedPathHeading).toBeInViewport()
320320
await expect(bazIdLink).toHaveAttribute('href', '/non-nested/baz/123')
@@ -338,8 +338,8 @@ test('Should not nest non-nested paths', async ({ page }) => {
338338
const bazIdEditHeading = page.getByTestId('non-nested-bazid-edit-heading')
339339
const bazIdEditParam = page.getByTestId('non-nested-bazid-edit-param')
340340
await expect(nonNestedPathHeading).toBeInViewport()
341-
await expect(bazHeading).not.toBeInViewport()
342-
await expect(bazIdHeading).not.toBeInViewport()
341+
await expect(bazHeading).toBeHidden()
342+
await expect(bazIdHeading).toBeHidden()
343343
await expect(bazIdEditHeading).toBeInViewport()
344344
await expect(bazIdEditParam).toContainText(JSON.stringify({ bazid: '456' }))
345345
})

‎e2e/solid-router/basic-file-based/src/routes/non-nested/route.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ function RouteComponent() {
2020
>
2121
/non-nested/baz/123
2222
</Link>
23+
</li>
24+
<li>
2325
<Link
2426
from={Route.fullPath}
2527
data-testid="l-to-non-nested-bazid-edit"

‎e2e/solid-router/basic-file-based/tests/app.spec.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -301,8 +301,8 @@ test('Should not nest non-nested paths', async ({ page }) => {
301301
await page.goto('/non-nested')
302302
await page.waitForURL('/non-nested')
303303
const nonNestedPathHeading = page.getByTestId('non-nested-path-heading')
304-
const bazIdLink = await page.getByTestId('l-to-non-nested-bazid')
305-
const bazIdEditLink = await page.getByTestId('l-to-non-nested-bazid-edit')
304+
const bazIdLink = page.getByTestId('l-to-non-nested-bazid')
305+
const bazIdEditLink = page.getByTestId('l-to-non-nested-bazid-edit')
306306

307307
await expect(nonNestedPathHeading).toBeInViewport()
308308
await expect(bazIdLink).toHaveAttribute('href', '/non-nested/baz/123')
@@ -326,8 +326,8 @@ test('Should not nest non-nested paths', async ({ page }) => {
326326
const bazIdEditHeading = page.getByTestId('non-nested-bazid-edit-heading')
327327
const bazIdEditParam = page.getByTestId('non-nested-bazid-edit-param')
328328
await expect(nonNestedPathHeading).toBeInViewport()
329-
await expect(bazHeading).not.toBeInViewport()
330-
await expect(bazIdHeading).not.toBeInViewport()
329+
await expect(bazHeading).toBeHidden()
330+
await expect(bazIdHeading).toBeHidden()
331331
await expect(bazIdEditHeading).toBeInViewport()
332332
await expect(bazIdEditParam).toContainText(JSON.stringify({ bazid: '456' }))
333333
})

0 commit comments

Comments
 (0)