You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 0d78d79
Browse filesBrowse the repository at this point in the historyBrowse files
committed
fix(solid-router): record a redirect while the first page loads as a navigation
A client-rendered arrival that redirects (a `beforeLoad` or loader
throwing `redirect()`) published its destination with no resolved
location to navigate from, so describeNavigation declared nothing and the
destination had no record: the initial record named the route the user
never saw, and nothing named the one they did.
Solid Router records it as a navigation of its own: the arrival's frame
has closed, so the redirect's location write is not a hop of a pending
navigation (`navigationDepth` is 0) and is declared from the arrival
(`from: "/files?x=1"`, no interaction, no `redirects`). Until the first
publish resolves a location, navigate from the arrival the initial record
names. A publish with no request behind it (the initial load itself) still
declares nothing.
Co-authored-by: Claude <[email protected]>
Co-authored-by: Cursor <[email protected]>
Observe tier (Solid's dev and observe builds only): a redirect while the first page loads — a client-rendered arrival whose `beforeLoad` or loader throws `redirect()` — is recorded as a navigation from the arrival to where the redirect sent it, after the initial record that names the arrival, as `@solidjs/router` records one. It had no record: nothing was shown yet to navigate from. Nothing changes in production, where `OBSERVE` is undefined.
0 commit comments