.changeset/red-monkeys-attack.md (1)

2-5: Minor bump is appropriate; clarify the user-facing change.

The version bump to minor makes sense (new flat config + type improvements). Consider making the summary explicitly mention the new flat/recommended preset and the compatibility fix for eslint/config’s defineConfig(), and link the issue to auto-close.

Apply this diff to tighten the message:

-feat: improve type of exported plugin
+feat: add `flat/recommended` preset and improve exported plugin types
+
+This makes `@tanstack/eslint-plugin-query` configs compatible with `eslint/config`’s `defineConfig()` and fixes the type mismatch reported in #9689.

packages/eslint-plugin-query/src/index.ts (3)

32-49: Avoid post-creation mutation; build the flat config without placeholders.

The placeholder {} plus the follow-up assignment works but is brittle and makes the object temporarily invalid. Consider constructing via a small factory/IIFE so the plugin self-reference is wired at creation time.

Example refactor (keeps your satisfies pattern, removes the mutation):

// above: import/types stay the same

const recommendedRules: Linter.RulesRecord = {
  '@tanstack/query/exhaustive-deps': 'error',
  '@tanstack/query/no-rest-destructuring': 'warn',
  '@tanstack/query/stable-query-client': 'error',
  '@tanstack/query/no-unstable-deps': 'error',
  '@tanstack/query/infinite-query-property-order': 'error',
  '@tanstack/query/no-void-query-fn': 'error',
  '@tanstack/query/mutation-property-order': 'error',
};

export const plugin = (() => {
  const core = {
    meta: { name: '@tanstack/eslint-plugin-query' },
    rules,
  } satisfies ESLint.Plugin & { rules: Record<RuleKey, RuleModule<any, any, any>> };

  return {
    ...core,
    configs: {
      recommended: {
        plugins: ['@tanstack/query'],
        rules: recommendedRules,
      },
      'flat/recommended': [
        {
          name: '@tanstack/query/flat/recommended',
          plugins: { '@tanstack/query': core },
          rules: recommendedRules,
        },
      ],
    },
  } satisfies Plugin;
})();

Minimal alternative (if you prefer to keep structure): assign core instead of plugin in the flat config’s plugins map; ESLint.Plugin doesn’t require configs, so core suffices.

---

34-34: Nit: include scope in the flat config name.

For clarity in tooling/debug output, prefer @tanstack/query/flat/recommended.

Apply this diff:

-        name: 'tanstack/query/flat/recommended',
+        name: '@tanstack/query/flat/recommended',

---

53-53: Remove non-null assertion and guard the mutation (or drop it per refactor).

If you keep the current pattern, avoid ! and add a small guard to prevent future refactors from throwing.

-plugin.configs['flat/recommended'][0]!.plugins['@tanstack/query'] = plugin
+const firstFlat = plugin.configs['flat/recommended'][0]
+if (firstFlat?.plugins) {
+  firstFlat.plugins['@tanstack/query'] = plugin
+}

Alternatively, adopt the factory approach above and delete this line entirely.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: oscartbeaumont
PR: TanStack/query#9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.