Conversation
Contributor
|
Warning Rate limit exceeded@arnoud-dv has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 45 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughDocumentation-only edits in packages/angular-query-experimental/src/mutation-options.ts: JSDoc examples were updated to demonstrate usage within a class context, using injected QueriesService, an idSignal, and injectMutation. No code logic, types, or public APIs changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 4e13e5d
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/angular-query-devtools-experimental
@tanstack/angular-query-experimental
@tanstack/eslint-plugin-query
@tanstack/query-async-storage-persister
@tanstack/query-broadcast-client-experimental
@tanstack/query-core
@tanstack/query-devtools
@tanstack/query-persist-client-core
@tanstack/query-sync-storage-persister
@tanstack/react-query
@tanstack/react-query-devtools
@tanstack/react-query-next-experimental
@tanstack/react-query-persist-client
@tanstack/solid-query
@tanstack/solid-query-devtools
@tanstack/solid-query-persist-client
@tanstack/svelte-query
@tanstack/svelte-query-devtools
@tanstack/svelte-query-persist-client
@tanstack/vue-query
@tanstack/vue-query-devtools
commit: |
Contributor
|
Sizes for commit 4e13e5d:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9648 +/- ##
===========================================
+ Coverage 45.51% 87.77% +42.25%
===========================================
Files 209 16 -193
Lines 8379 319 -8060
Branches 1905 75 -1830
===========================================
- Hits 3814 280 -3534
+ Misses 4118 34 -4084
+ Partials 447 5 -442
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/angular-query-experimental/src/mutation-options.ts(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
Comment on lines
+86
to
+92
| * class ComponentOrService { | ||
| * queries = inject(QueriesService) | ||
| * idSignal = new Signal(0); | ||
| * mutation = injectMutation(() => this.queries.updatePost(this.idSignal())) | ||
| * } | ||
| * | ||
| * mutation.mutate({ title: 'New Title' }) | ||
| * this.mutation.mutate({ title: 'New Title' }) |
Contributor
There was a problem hiding this comment.
Duplicate snippet: apply the same fixes here
Mirror the same corrections: use signal(0), keep mutate inside the class (e.g., save()), and add semicolons.
- class ComponentOrService {
- queries = inject(QueriesService)
- idSignal = new Signal(0);
- mutation = injectMutation(() => this.queries.updatePost(this.idSignal()))
- }
-
- this.mutation.mutate({ title: 'New Title' })
+ class ComponentOrService {
+ queries = inject(QueriesService);
+ idSignal = signal(0);
+ mutation = injectMutation(() => this.queries.updatePost(this.idSignal()));
+
+ save() {
+ this.mutation.mutate({ title: 'New Title' });
+ }
+ }Note: the snippet assumes import { inject, signal } from '@angular/core'.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| * class ComponentOrService { | |
| * queries = inject(QueriesService) | |
| * idSignal = new Signal(0); | |
| * mutation = injectMutation(() => this.queries.updatePost(this.idSignal())) | |
| * } | |
| * | |
| * mutation.mutate({ title: 'New Title' }) | |
| * this.mutation.mutate({ title: 'New Title' }) | |
| * class ComponentOrService { | |
| * queries = inject(QueriesService); | |
| * idSignal = signal(0); | |
| * mutation = injectMutation(() => this.queries.updatePost(this.idSignal())); | |
| * | |
| * save() { | |
| * this.mutation.mutate({ title: 'New Title' }); | |
| * } | |
| * } |
🤖 Prompt for AI Agents
In packages/angular-query-experimental/src/mutation-options.ts around lines 86
to 92, the example uses the old `new Signal(0)` pattern, places `mutate` call
outside a class method, and is missing semicolons; change `new Signal(0)` to
`signal(0)`, keep the mutate invocation inside the class (e.g., implement a
`save()` method that calls `this.mutation.mutate({...});`), add missing
semicolons to statements, and ensure the example notes the required import
`import { inject, signal } from '@angular/core'`.
arnoud-dv
force-pushed
the
docs/angular-query-improve-mutation-options-jsdoc
branch
2 times, most recently
from
105d357 to
9ee61a9
Compare
arnoud-dv
force-pushed
the
docs/angular-query-improve-mutation-options-jsdoc
branch
from
9ee61a9 to
4e13e5d
Compare
arnoud-dv
deleted the
docs/angular-query-improve-mutation-options-jsdoc
branch
Hellol77
pushed a commit
to Hellol77/query
that referenced
this pull request
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that it's inside a class - if AI tooling doesn't understand that it's confusing for humans too.
Summary by CodeRabbit