Skip to content

[alpha][fix-5538] : sync Observer 'current' properties when optimistic reading occurs #5611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TkDodo merged 12 commits into from
Jul 14, 2023
Merged

[alpha][fix-5538] : sync Observer 'current' properties when optimistic reading occurs #5611

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c9712d4
fix-5538 : sync Observer 'current' properties when optimistic readin…
incepter Jun 19, 2023
ead1b59
Flip test on currentResult with placeholderData's order & add test
incepter Jun 20, 2023
d55e8e8
Merge branch 'alpha' into alpha/fix-5538
TkDodo Jun 23, 2023
a017016
Fix tests using the same queryKey
incepter Jun 23, 2023
14703aa
remove options.placeHolderData from deciding whether to assign observ…
incepter Jun 26, 2023
62fd9cd
Merge branch 'alpha' into alpha/fix-5538
TkDodo Jun 26, 2023
3930efc
maybe fix for vue reactivity cbs
incepter Jun 26, 2023
f4547ab
Merge branch 'alpha' into alpha/fix-5538
TkDodo Jun 27, 2023
5510f3d
Merge branch 'alpha' into alpha/fix-5538
TkDodo Jun 27, 2023
2f99fca
test(vue-query): test persister with useQuery
DamianOsipiuk Jun 30, 2023
6f0a469
Force line terminator to \\n on codemods tests
incepter Jul 3, 2023
a830410
Revert " Force line terminator to \\n on codemods tests"
incepter Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
maybe fix for vue reactivity cbs
  • Loading branch information
@incepter
incepter committed Jun 26, 2023
commit 3930efcf4b18d7a1341621f081dd4319768f89a8
5 changes: 4 additions & 1 deletion packages/vue-query/src/useQueries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,10 @@ export function useQueries<
defaultedQueries.value,
options as QueriesObserverOptions<TCombinedResult>,
)
state.value = observer.getCurrentResult()
const [, getCombinedResultPersisted] = observer.getOptimisticResult(
defaultedQueries.value,
)
state.value = getCombinedResultPersisted()
Comment thread
TkDodo marked this conversation as resolved.
},
{ deep: true },
)
Expand Down