Skip to content

chore: Update to pnpm v8#5476

Merged
lachlancollins merged 6 commits intoTanStack:mainfrom
lachlancollins:pnpm-v8
May 27, 2023
Merged

chore: Update to pnpm v8#5476
lachlancollins merged 6 commits intoTanStack:mainfrom
lachlancollins:pnpm-v8

Conversation

@lachlancollins
Copy link
Copy Markdown
Member

@lachlancollins lachlancollins commented May 26, 2023

The main branch is already using lockfile version 6.0 (pnpm v8), while the alpha branch has lockfile version 5.4 (pnpm v7). Can't think of any reason against updating (see changes here), and it should mean github actions run faster since it doesn't need to regenerate the lockfile back to 5.4.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) May 27, 2023 1:53am

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 26, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ff710b8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented May 26, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@lachlancollins
Copy link
Copy Markdown
Member Author

lachlancollins commented May 26, 2023

@TkDodo I spoke too soon - codesandbox doesn't use pnpm 8 yet. If I allow it to regen the pnpm lockfile it works, which isn't necessary for github actions. I don't quite understand why codesandbox hasn't been throwing errors since it's been using lockfile v6.0 for a while!

EDIT: Fixed by using corepack

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 26, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: +0.43 🎉

Comparison is base (3816c9d) 91.79% compared to head (ff710b8) 92.23%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5476      +/-   ##
==========================================
+ Coverage   91.79%   92.23%   +0.43%     
==========================================
  Files         101      112      +11     
  Lines        3889     4276     +387     
  Branches      974     1116     +142     
==========================================
+ Hits         3570     3944     +374     
- Misses        298      311      +13     
  Partials       21       21              
Impacted Files Coverage Δ
...ackages/eslint-plugin-query/src/utils/ast-utils.ts 94.48% <66.66%> (ø)
...src/rules/exhaustive-deps/exhaustive-deps.utils.ts 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lachlancollins lachlancollins requested a review from TkDodo May 27, 2023 00:02
@lachlancollins lachlancollins merged commit 6c3abf7 into TanStack:main May 27, 2023
@lachlancollins lachlancollins deleted the pnpm-v8 branch May 27, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants