Skip to content

test(angular-query-experimental/injectIsMutating): add filter test by 'mutationKey'#10595

Merged
sukvvon merged 1 commit intomainfrom
test/angular-query-inject-is-mutating-add-filter-test
Apr 26, 2026
Merged

test(angular-query-experimental/injectIsMutating): add filter test by 'mutationKey'#10595
sukvvon merged 1 commit intomainfrom
test/angular-query-inject-is-mutating-add-filter-test

Conversation

@sukvvon
Copy link
Copy Markdown
Collaborator

@sukvvon sukvvon commented Apr 26, 2026 •
edited by coderabbitai Bot
Loading

🎯 Changes

Add a test that asserts injectIsMutating({ mutationKey }) only counts mutations matching the given key, not all in-flight mutations. The existing test only covered the unfiltered count; this completes the API by also locking down the filter path.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Tests
    • Added test coverage for mutation key filtering in asynchronous operations, ensuring concurrent operations with distinct identifiers are properly tracked and reported.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ea32344d-b92b-4d53-b549-42a24b1d2ebc

📥 Commits

Reviewing files that changed from the base of the PR and between 7a5b53c and ff2d13e.

📒 Files selected for processing (1)
  • packages/angular-query-experimental/src/__tests__/inject-is-mutating.test.ts
📝 Walkthrough

Walkthrough

A new unit test is added for the injectIsMutating hook in the Angular Query experimental package. The test verifies that the mutation key filtering works correctly by tracking two concurrent mutations with distinct keys and asserting the filtered signal state at different time intervals.

Changes

Cohort / File(s) Summary
New Test File
packages/angular-query-experimental/src/__tests__/inject-is-mutating.test.ts		 New unit test exercising injectIsMutating with mutationKey filtering, verifying correct signal state when multiple concurrent mutations are in flight and a filtered signal is constrained to a single key.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

package: angular-query-experimental

Poem

🐰 A test hops in with mutations two,
Keys distinct, filtering rings true,
Signals dance when timers tick,
isMutating gets the logic trick! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a filter test by 'mutationKey' for injectIsMutating.
Description check ✅ Passed The description follows the template structure with all required sections completed: Changes section explains the test addition, both checklist items are marked as completed, and Release Impact correctly identifies this as dev-only.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/angular-query-inject-is-mutating-add-filter-test

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 26, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ff2d13e

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 40s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-26 08:53:54 UTC

@sukvvon sukvvon self-assigned this Apr 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 26, 2026

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 26, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10595

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10595

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10595

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10595

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10595

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10595

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10595

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10595

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10595

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10595

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10595

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10595

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10595

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10595

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10595

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10595

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10595

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10595

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10595

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10595

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10595

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10595

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10595

commit: ff2d13e

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 26, 2026

size-limit report 📦

Path Size
react full 12.1 KB (0%)
react minimal 9.07 KB (0%)

@sukvvon sukvvon merged commit c9755be into main Apr 26, 2026
10 checks passed
@sukvvon sukvvon deleted the test/angular-query-inject-is-mutating-add-filter-test branch April 26, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sukvvon sukvvon

Labels

package: angular-query-experimental

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sukvvon