Skip to content

fix/nodejs timeout#10325

Merged
TkDodo merged 4 commits intomainfrom
feature/nodejs-timeout
Mar 23, 2026
Merged

fix/nodejs timeout#10325
TkDodo merged 4 commits intomainfrom
feature/nodejs-timeout

Conversation

@TkDodo
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo commented Mar 23, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Bug Fixes

    • Fixed a potential memory leak in timeout handling for Node.js environments

  • Chores

    • Updated build configurations across packages for improved compilation scoping

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 23, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 296c35fe-e2e3-4ca4-ac99-18597e9321bd

📥 Commits

Reviewing files that changed from the base of the PR and between 5806444 and fac5cad.

📒 Files selected for processing (5)
  • .changeset/funny-views-build.md
  • packages/preact-query/tsconfig.prod.json
  • packages/query-core/tsconfig.prod.json
  • packages/react-query/tsconfig.prod.json
  • packages/solid-query/tsconfig.prod.json
📝 Walkthrough

Walkthrough

The PR adds a changeset documenting a timeout manager fix in @tanstack/query-core and updates TypeScript production configurations across multiple query packages to explicitly include the src directory during compilation.

Changes

Cohort / File(s) Summary
Release Documentation
.changeset/funny-views-build.md		 New changeset file recording a patch version bump for @tanstack/query-core with a fix entry for NodeJS timeout manager leak prevention.
TypeScript Production Configuration
packages/preact-query/tsconfig.prod.json, packages/query-core/tsconfig.prod.json, packages/react-query/tsconfig.prod.json, packages/solid-query/tsconfig.prod.json		 Added explicit include: ["src"] directive to production TypeScript configurations, replacing reliance on default include behavior while maintaining existing test exclusions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 With src directories now in sight,
TypeScript configs, crisp and tight,
No more guessing what to compile,
A timeout fix worth all the while! 🎉

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/nodejs-timeout

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 23, 2026 •
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.

View your CI Pipeline Execution ↗ for commit fac5cad

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 3m 55s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-23 14:51:35 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 23, 2026

🚀 Changeset Version Preview

1 package(s) bumped directly, 23 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/query-core 5.95.1 → 5.95.2 Changeset
@tanstack/angular-query-experimental 5.95.1 → 5.95.2 Dependent
@tanstack/angular-query-persist-client 5.95.1 → 5.95.2 Dependent
@tanstack/eslint-plugin-query 5.95.1 → 5.95.2 Dependent
@tanstack/preact-query 5.95.1 → 5.95.2 Dependent
@tanstack/preact-query-devtools 5.95.1 → 5.95.2 Dependent
@tanstack/preact-query-persist-client 5.95.1 → 5.95.2 Dependent
@tanstack/query-async-storage-persister 5.95.1 → 5.95.2 Dependent
@tanstack/query-broadcast-client-experimental 5.95.1 → 5.95.2 Dependent
@tanstack/query-devtools 5.95.1 → 5.95.2 Dependent
@tanstack/query-persist-client-core 5.95.1 → 5.95.2 Dependent
@tanstack/query-sync-storage-persister 5.95.1 → 5.95.2 Dependent
@tanstack/react-query 5.95.1 → 5.95.2 Dependent
@tanstack/react-query-devtools 5.95.1 → 5.95.2 Dependent
@tanstack/react-query-next-experimental 5.95.1 → 5.95.2 Dependent
@tanstack/react-query-persist-client 5.95.1 → 5.95.2 Dependent
@tanstack/solid-query 5.95.1 → 5.95.2 Dependent
@tanstack/solid-query-devtools 5.95.1 → 5.95.2 Dependent
@tanstack/solid-query-persist-client 5.95.1 → 5.95.2 Dependent
@tanstack/svelte-query 6.1.9 → 6.1.10 Dependent
@tanstack/svelte-query-devtools 6.1.9 → 6.1.10 Dependent
@tanstack/svelte-query-persist-client 6.1.9 → 6.1.10 Dependent
@tanstack/vue-query 5.95.1 → 5.95.2 Dependent
@tanstack/vue-query-devtools 6.1.9 → 6.1.10 Dependent

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 23, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10325

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10325

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10325

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10325

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10325

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10325

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10325

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10325

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10325

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10325

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10325

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10325

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10325

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10325

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10325

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10325

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10325

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10325

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10325

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10325

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10325

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10325

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10325

commit: fac5cad

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 23, 2026

size-limit report 📦

Path Size
react full 11.98 KB (0%)
react minimal 9.01 KB (0%)

@TkDodo TkDodo marked this pull request as ready for review March 23, 2026 14:58
@TkDodo TkDodo merged commit cd5a35b into main Mar 23, 2026
8 of 10 checks passed
@TkDodo TkDodo deleted the feature/nodejs-timeout branch March 23, 2026 14:58
@TkDodo TkDodo linked an issue Mar 23, 2026 that may be closed by this pull request
@types/node types leak into browser/client projects in version 5.91.0 #10294
Closed
@github-actions github-actions Bot mentioned this pull request Mar 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: preact-query package: query-core package: react-query package: solid-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@types/node types leak into browser/client projects in version 5.91.0

1 participant

@TkDodo