test(react-query/useQuery): add test for not fetching during restoring period when 'isRestoring' is true by sukvvon · Pull Request #10166 · TanStack/query

sukvvon · 2026-02-22T12:55:58Z

🎯 Changes

Add a test to cover the isRestoring branch in useBaseQuery.ts (line 78).

When IsRestoringProvider provides true, the query should remain in pending status with fetchStatus: 'idle' and never call queryFn, even after the query's sleep duration has elapsed.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added test coverage verifying that queries remain idle and do not fetch during the restoration state, ensuring expected behavior is maintained.

…g period when 'isRestoring' is true

changeset-bot · 2026-02-22T12:56:03Z

⚠️ No Changeset found

Latest commit: 9c52153

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-02-22T12:56:18Z

No actionable comments were generated in the recent review. 🎉

📝 Walkthrough

Walkthrough

A new test case is added to verify that useQuery respects the isRestoring state, ensuring queries remain idle and don't trigger fetches when the restoring provider indicates an active restoration period.

Changes

Cohort / File(s)	Summary
useQuery Test Suite `packages/react-query/src/__tests__/useQuery.test.tsx`	Added test scenario importing `IsRestoringProvider` to verify that useQuery does not initiate fetches during the restoring window, with assertions confirming pending status, idle fetchStatus, undefined data, and no queryFn invocation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

TkDodo
manudeli

Poem

🐰 A test hops in with restoring grace,
To keep the queries in their place,
No fetches while the state's restored,
The idle fetchStatus is adored!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately describes the main change: adding a test for the isRestoring behavior in useQuery, which directly corresponds to the test file modifications.
Description check	✅ Passed	The PR description follows the template structure with all required sections completed: Changes section explains the test's purpose clearly, Checklist items are marked appropriately, and Release Impact correctly identifies it as dev-only.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-02-22T12:56:28Z

View your CI Pipeline Execution ↗ for commit 9c52153

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-22 13:02:25 UTC

pkg-pr-new · 2026-02-22T12:57:54Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10166

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10166

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10166

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10166

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10166

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10166

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10166

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10166

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10166

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10166

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10166

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10166

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10166

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10166

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10166

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10166

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10166

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10166

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10166

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10166

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10166

commit: 9c52153

test(react-query/useQuery): add test for not fetching during restorin…

cfae4ab

…g period when 'isRestoring' is true

github-actions Bot added the package: react-query label Feb 22, 2026

ci: apply automated fixes

78ab024

Merge branch 'main' into test/react-query-useBaseQuery-isRestoring

9c52153

TkDodo merged commit 808d84a into TanStack:main Feb 26, 2026
7 checks passed

coderabbitai Bot mentioned this pull request Feb 27, 2026

test(react-query/useQueries): add test for not fetching during restoring period when 'isRestoring' is true #10196

Merged

4 tasks

sukvvon self-assigned this Mar 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(react-query/useQuery): add test for not fetching during restoring period when 'isRestoring' is true#10166

test(react-query/useQuery): add test for not fetching during restoring period when 'isRestoring' is true#10166
TkDodo merged 3 commits intoTanStack:mainfrom
sukvvon:test/react-query-useBaseQuery-isRestoring

sukvvon commented Feb 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Feb 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Feb 22, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Feb 22, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Feb 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sukvvon commented Feb 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sukvvon commented Feb 22, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Feb 22, 2026 •

edited

Loading

coderabbitai Bot commented Feb 22, 2026 •

edited

Loading

nx-cloud Bot commented Feb 22, 2026 •

edited

Loading

pkg-pr-new Bot commented Feb 22, 2026 •

edited

Loading