test(preact-query/useSuspenseQueries): add test for suspending only pending queries when some already have cached data by sukvvon · Pull Request #10133 · TanStack/query

sukvvon · 2026-02-14T03:18:24Z

🎯 Changes

Add a test case for useSuspenseQueries to verify that only pending queries suspend when some queries already have cached data via setQueryData.

One query has cached data, the other needs to fetch
Component should suspend until the pending query resolves
After resolution, cached query retains its cached value while the other shows fetched data

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added test coverage for query suspension behavior when mixing cached and pending data sources.

…ending queries when some already have cached data

changeset-bot · 2026-02-14T03:18:29Z

⚠️ No Changeset found

Latest commit: d03f6c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-02-14T03:18:49Z

View your CI Pipeline Execution ↗ for commit d03f6c2

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 18s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-14 03:20:44 UTC

coderabbitai · 2026-02-14T03:18:51Z

📝 Walkthrough

Walkthrough

Adds a test case to verify that useSuspenseQueries returns cached data immediately for queries with existing data while only pending queries trigger suspension, validating behavior with mixed cached and pending query states.

Changes

Cohort / File(s)	Summary
Test Case Addition `packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx`	New test case verifying mixed cached/pending query handling: confirms cached data is returned immediately for key1 while key2 suspends until resolved.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

refactor(react-query/useQueries): remove unreachable 'willFetch' branch in suspense promise collection #10082: Refactors suspense promise collection in useQueries by removing an unreachable willFetch branch, directly affecting when fetchOptimistic is invoked for mixed cached/pending query scenarios that this test validates.

Suggested reviewers

manudeli
TkDodo

Poem

🐰 A test hops in with queries galore,
Some cached, some pending—what's in store?
Suspense waits kindly for those yet to bloom,
While cached ones bound through the Preact room!

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: adding a test for useSuspenseQueries behavior with partial cached data, which directly matches the code changes.
Description check	✅ Passed	The description covers all required sections from the template with complete information about changes, checklist items completed, and release impact clearly marked.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into `main`

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-02-14T03:20:19Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10133

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10133

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10133

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10133

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10133

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10133

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10133

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10133

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10133

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10133

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10133

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10133

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10133

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10133

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10133

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10133

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10133

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10133

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10133

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10133

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10133

commit: d03f6c2

…ending queries when some already have cached data (TanStack#10133)

test(preact-query/useSuspenseQueries): add test for suspending only p…

d03f6c2

…ending queries when some already have cached data

github-actions Bot added the package: preact-query label Feb 14, 2026

TkDodo merged commit 984bfa6 into TanStack:main Feb 16, 2026
7 checks passed

DogPawHat pushed a commit to DogPawHat/query that referenced this pull request Feb 23, 2026

test(preact-query/useSuspenseQueries): add test for suspending only p…

74fb33c

…ending queries when some already have cached data (TanStack#10133)

coderabbitai Bot mentioned this pull request Feb 26, 2026

refactor(preact-query/useQueries): remove unreachable 'willFetch' branch in suspense promise collection #10188

Merged

4 tasks

JoviDeCroock pushed a commit to JoviDeCroock/react-query that referenced this pull request Feb 26, 2026

test(preact-query/useSuspenseQueries): add test for suspending only p…

20f9118

…ending queries when some already have cached data (TanStack#10133)

sukvvon self-assigned this Mar 19, 2026

coderabbitai Bot mentioned this pull request Mar 28, 2026

test({react,preact}-query/useSuspenseQueries): add test for not suspending but only refetching the stale query when one query has fresh and the other has stale cached data #10345

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(preact-query/useSuspenseQueries): add test for suspending only pending queries when some already have cached data#10133

test(preact-query/useSuspenseQueries): add test for suspending only pending queries when some already have cached data#10133
TkDodo merged 1 commit intoTanStack:mainfrom
sukvvon:test/preact-query-useSuspenseQueries-partial-cached-suspend

sukvvon commented Feb 14, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Feb 14, 2026

Uh oh!

nx-cloud Bot commented Feb 14, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Feb 14, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

pkg-pr-new Bot commented Feb 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sukvvon commented Feb 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Feb 14, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

pkg-pr-new Bot commented Feb 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sukvvon commented Feb 14, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Feb 14, 2026 •

edited

Loading

coderabbitai Bot commented Feb 14, 2026 •

edited

Loading