fix(query-core): stop wrapping persister generics in NoInfer (#10510)

ousamabenyounes · claude · TkDodo · web-flow · commit ea4497e8aa00 · 2026-04-25T11:37:25.000+02:00
* fix(query-core): stop wrapping persister generics in NoInfer The `persister` field on QueryOptions was typed as `QueryPersister<NoInfer<TQueryFnData>, NoInfer<TQueryKey>, NoInfer<TPageParam>>` so persister could not contribute to TQueryFnData inference. When the companion queryFn declared a parameter (e.g. `(_context) => 'test'`), TypeScript failed to infer TQueryFnData from its return and defaulted to `unknown`, causing a spurious overload mismatch against a concretely-typed persister (fixes #7842). Removing the NoInfer wrappers lets persister participate in inference. Genuine type conflicts between persister and queryFn still surface as errors (covered by a new negative type test in queryOptions.test-d.tsx). Co-Authored-By: Claude <noreply@anthropic.com> * test(react-query): wrap negative type tests in assertType Addresses CodeRabbit nitpick: vitest/expect-expect flagged the genuine-conflict test as having no assertions. Wrap both calls in assertType() so the linter sees an explicit assertion while the `@ts-expect-error` directives continue to enforce the type mismatch. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Dominik Dorfmeister 🔮 <office@dorfmeister.cc>
diff --git a/.changeset/fix-persister-infer-when-queryfn-has-parameter.md b/.changeset/fix-persister-infer-when-queryfn-has-parameter.md
@@ -0,0 +1,5 @@
+---
+'@tanstack/query-core': patch
+---
+
+fix(query-core): allow `persister` to contribute to `TQueryFnData` inference so a `queryFn` that declares a parameter no longer produces a spurious overload mismatch against a typed persister (#7842).
diff --git a/packages/query-core/src/types.ts b/packages/query-core/src/types.ts
@@ -246,11 +246,7 @@ export interface QueryOptions<
    */
   gcTime?: number
   queryFn?: QueryFunction<TQueryFnData, TQueryKey, TPageParam> | SkipToken
-  persister?: QueryPersister<
-    NoInfer<TQueryFnData>,
-    NoInfer<TQueryKey>,
-    NoInfer<TPageParam>
-  >
+  persister?: QueryPersister<TQueryFnData, TQueryKey, TPageParam>
   queryHash?: string
   queryKey?: TQueryKey
   queryKeyHashFn?: QueryKeyHashFunction<TQueryKey>
diff --git a/packages/react-query/src/__tests__/queryOptions.test-d.tsx b/packages/react-query/src/__tests__/queryOptions.test-d.tsx
@@ -15,6 +15,7 @@ import type {
   DataTag,
   InitialDataFunction,
   QueryObserverResult,
+  QueryPersister,
 } from '@tanstack/query-core'
 
 describe('queryOptions', () => {
@@ -284,4 +285,40 @@ describe('queryOptions', () => {
       DataTag<MyQueryKey, number, Error & { myMessage: string }>
     >()
   })
+
+  it('should infer TQueryFnData from persister paired with a queryFn declaring a parameter (#7842)', () => {
+    const persister = undefined as unknown as QueryPersister<string, any>
+
+    const options = queryOptions({
+      queryKey: ['key'],
+      queryFn: (_context) => 'hello',
+      persister,
+    })
+
+    expectTypeOf(options.queryFn!).returns.toEqualTypeOf<
+      string | Promise<string>
+    >()
+  })
+
+  it('should still error when persister and queryFn return types genuinely conflict', () => {
+    const persister = undefined as unknown as QueryPersister<string, any>
+
+    assertType(
+      queryOptions({
+        queryKey: ['key'],
+        // @ts-expect-error persister expects string, queryFn returns number
+        queryFn: () => 42,
+        persister,
+      }),
+    )
+
+    assertType(
+      queryOptions({
+        queryKey: ['key'],
+        // @ts-expect-error persister expects string, queryFn with arg returns number
+        queryFn: (_context) => 42,
+        persister,
+      }),
+    )
+  })
 })

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@tanstack/query-core': patch
 +---
++
 +fix(query-core): allow `persister` to contribute to `TQueryFnData` inference so a `queryFn` that declares a parameter no longer produces a spurious overload mismatch against a typed persister (#7842).