Skip to content

Commit cacc758

Browse files
committed
test({react,preact}-query/useSuspenseQueries): replace '[1] as const' with 'queryKey()' util and fix 'act' callback type in preact-query
1 parent 93e908f commit cacc758

2 files changed

Lines changed: 14 additions & 6 deletions

File tree

packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,14 +103,16 @@ describe('useSuspenseQueries', () => {
103103
</Suspense>,
104104
)
105105

106-
await act(() => vi.advanceTimersByTimeAsync(1000))
106+
await act(async () => {
107+
await vi.advanceTimersByTimeAsync(1000)
108+
})
107109

108110
expect(onQueriesResolution).toHaveBeenCalledTimes(1)
109111
expect(onQueriesResolution).toHaveBeenLastCalledWith([1, 2])
110112
})
111113

112114
it('should not suspend on mount if query has been already fetched', () => {
113-
const key = [1] as const
115+
const key = queryKey()
114116
const queryFn = () => sleep(1000).then(() => 1)
115117

116118
queryClient.setQueryData(key, queryFn)
@@ -182,7 +184,9 @@ describe('useSuspenseQueries', () => {
182184
</Suspense>,
183185
)
184186

185-
await vi.advanceTimersByTimeAsync(1000)
187+
await act(async () => {
188+
await vi.advanceTimersByTimeAsync(1000)
189+
})
186190

187191
expect(onSuspend).toHaveBeenCalled()
188192
// the test for onQueriesResolution is React-specific and not applicable to Preact
@@ -224,15 +228,19 @@ describe('useSuspenseQueries', () => {
224228
</Suspense>,
225229
)
226230

227-
await act(() => vi.advanceTimersByTimeAsync(1000))
231+
await act(async () => {
232+
await vi.advanceTimersByTimeAsync(1000)
233+
})
228234

229235
rerender(
230236
<Suspense fallback={<SuspenseFallback />}>
231237
<Page queries={nextQueries} />
232238
</Suspense>,
233239
)
234240

235-
await act(() => vi.advanceTimersByTimeAsync(1000))
241+
await act(async () => {
242+
await vi.advanceTimersByTimeAsync(1000)
243+
})
236244

237245
expect(onSuspend).toHaveBeenCalledTimes(2)
238246
expect(onQueriesResolution).toHaveBeenCalledTimes(2)

packages/react-query/src/__tests__/useSuspenseQueries.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ describe('useSuspenseQueries', () => {
108108
})
109109

110110
it('should not suspend on mount if query has been already fetched', () => {
111-
const key = [1] as const
111+
const key = queryKey()
112112
const queryFn = () => sleep(1000).then(() => 1)
113113

114114
queryClient.setQueryData(key, queryFn)

0 commit comments

Comments
 (0)