test(build): add regression test for build tool type leaks in .d.ts files

ma-cote · ma-cote · commit caad915a52a4 · 2026-03-30T15:08:23.000-04:00
Adds scripts/verify-dts-imports.ts that scans all published .d.ts files
for forbidden imports from build tools (vite, tsup, vitest) and
`/// &lt;reference types="node" /&gt;`. Wired into test:pr and test:ci to
run after the build completes.
diff --git a/package.json b/package.json
@@ -10,14 +10,15 @@
   "scripts": {
     "clean": "pnpm --filter \"./packages/**\" run clean",
     "test": "pnpm run test:ci",
-    "test:pr": "nx affected --targets=test:sherif,test:knip,test:docs,test:eslint,test:lib,test:types,test:build,build",
-    "test:ci": "nx run-many --targets=test:sherif,test:knip,test:docs,test:eslint,test:lib,test:types,test:build,build",
+    "test:pr": "nx affected --targets=test:sherif,test:knip,test:docs,test:eslint,test:lib,test:types,test:build,build && pnpm run test:build:dts",
+    "test:ci": "nx run-many --targets=test:sherif,test:knip,test:docs,test:eslint,test:lib,test:types,test:build,build && pnpm run test:build:dts",
     "test:eslint": "nx affected --target=test:eslint",
     "test:sherif": "sherif -i typescript -p \"./integrations/*\" -p \"./examples/*\"",
     "test:size": "size-limit",
     "test:lib": "nx affected --target=test:lib --exclude=examples/**",
     "test:lib:dev": "pnpm run test:lib && nx watch --all -- pnpm run test:lib",
     "test:build": "nx affected --target=test:build --exclude=examples/**",
+    "test:build:dts": "node scripts/verify-dts-imports.ts",
     "test:types": "nx affected --target=test:types --exclude=examples/**",
     "test:knip": "knip --treat-config-hints-as-errors",
     "test:docs": "node scripts/verify-links.ts",
diff --git a/scripts/verify-dts-imports.ts b/scripts/verify-dts-imports.ts
@@ -0,0 +1,47 @@
+import { readFileSync } from 'node:fs'
+import { glob } from 'tinyglobby'
+
+const FORBIDDEN_PATTERNS = [
+  /\bfrom\s+['"]vite['"]/,
+  /\bfrom\s+['"]tsup['"]/,
+  /\bfrom\s+['"]vitest/,
+  /\/\/\/\s*<reference\s+types=["']node["']\s*\/>/,
+]
+
+const errors: Array<{ file: string; line: number; text: string }> = []
+
+const files = await glob(['packages/*/build/**/*.d.ts', 'packages/*/build/**/*.d.cts'])
+
+for (const file of files) {
+  const content = readFileSync(file, 'utf-8')
+  const lines = content.split('\n')
+  for (let i = 0; i < lines.length; i++) {
+    const line = lines[i]!
+    for (const pattern of FORBIDDEN_PATTERNS) {
+      if (pattern.test(line)) {
+        errors.push({ file, line: i + 1, text: line.trim() })
+      }
+    }
+  }
+}
+
+if (errors.length > 0) {
+  console.error(
+    'ERROR: Build tool types leaked into published .d.ts files:\n',
+  )
+  for (const error of errors) {
+    console.error(`  ${error.file}:${error.line}`)
+    console.error(`    ${error.text}\n`)
+  }
+  console.error(
+    'This usually means a tsconfig.prod.json is missing "include": ["src"].',
+  )
+  console.error(
+    'See https://github.com/TanStack/query/issues/10294 for details.',
+  )
+  process.exit(1)
+} else {
+  console.log(
+    `Verified ${files.length} .d.ts files — no build tool type leaks found.`,
+  )
+}
