Skip to content

Commit bda295e

Browse files
committed
fix: coderabbit comments
1 parent 1476ca5 commit bda295e

9 files changed

Lines changed: 8 additions & 19 deletions

File tree

docs/framework/react/typescript.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ React Query is now written in **TypeScript** to make sure the library and your p
88
Things to keep in mind:
99

1010
- TanStack Query follows [DefinitelyTyped's support window](https://github.com/DefinitelyTyped/DefinitelyTyped#support-window) and supports TypeScript versions released within the last 2 years. At the moment, that means TypeScript **5.4** and newer.
11+
- The current stable compiler lane is TypeScript **5.9**. We also run a separate `ts60` test lane against TypeScript `6.0.1-rc` and will switch that alias to a stable `6.0.x` release once TypeScript 6 is published.
1112
- Changes to types in this repository are considered **non-breaking** and are usually released as **patch** semver changes (otherwise every type enhancement would be a major version!).
1213
- It is **highly recommended that you lock your react-query package version to a specific patch release and upgrade with the expectation that types may be fixed or upgraded between any release**
1314
- The non-type-related public API of React Query still follows semver very strictly.

docs/framework/solid/typescript.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ Solid Query is written in **TypeScript** to make sure the library and your proje
88
Things to keep in mind:
99

1010
- TanStack Query follows [DefinitelyTyped's support window](https://github.com/DefinitelyTyped/DefinitelyTyped#support-window) and supports TypeScript versions released within the last 2 years. At the moment, that means TypeScript **5.4** and newer.
11+
- The current stable compiler lane is TypeScript **5.9**. We also run a separate `ts60` test lane against TypeScript `6.0.1-rc` and will switch that alias to a stable `6.0.x` release once TypeScript 6 is published.
1112
- Changes to types in this repository are considered **non-breaking** and are usually released as **patch** semver changes (otherwise every type enhancement would be a major version!).
1213
- It is **highly recommended that you lock your solid-query package version to a specific patch release and upgrade with the expectation that types may be fixed or upgraded between any release**
1314
- The non-type-related public API of Solid Query still follows semver very strictly.

packages/angular-query-experimental/tsup.config.ts

Lines changed: 0 additions & 13 deletions
This file was deleted.

packages/eslint-plugin-query/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
},
7070
"peerDependencies": {
7171
"eslint": "^8.57.0 || ^9.0.0",
72-
"typescript": "^5.0.0"
72+
"typescript": "^5.4.0"
7373
},
7474
"peerDependenciesMeta": {
7575
"typescript": {

packages/preact-query-devtools/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"test:types:ts58": "node ../../node_modules/typescript58/lib/tsc.js --build tsconfig.legacy.json",
2727
"test:types:ts59": "node ../../node_modules/typescript59/lib/tsc.js --build tsconfig.legacy.json",
2828
"test:types:tscurrent": "tsc --build",
29-
"test:types:ts60": "node ../../node_modules/typescript60/lib/tsc.js --build",
29+
"test:types:ts60": "node ../../node_modules/typescript60/lib/tsc.js --build tsconfig.legacy.json",
3030
"test:build": "publint --strict && attw --pack",
3131
"build": "tsup --tsconfig tsconfig.prod.json",
3232
"build:dev": "tsup --watch"

packages/query-core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"test:types:ts58": "node ../../node_modules/typescript58/lib/tsc.js --build tsconfig.legacy.json",
2727
"test:types:ts59": "node ../../node_modules/typescript59/lib/tsc.js --build tsconfig.legacy.json",
2828
"test:types:tscurrent": "tsc --build",
29-
"test:types:ts60": "node ../../node_modules/typescript60/lib/tsc.js --build",
29+
"test:types:ts60": "node ../../node_modules/typescript60/lib/tsc.js --build tsconfig.legacy.json",
3030
"test:lib": "vitest",
3131
"test:lib:dev": "pnpm run test:lib --watch",
3232
"test:build": "publint --strict && attw --pack",

packages/react-query-persist-client/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"test:types:ts58": "node ../../node_modules/typescript58/lib/tsc.js --build tsconfig.legacy.json",
2727
"test:types:ts59": "node ../../node_modules/typescript59/lib/tsc.js --build tsconfig.legacy.json",
2828
"test:types:tscurrent": "tsc --build",
29-
"test:types:ts60": "node ../../node_modules/typescript60/lib/tsc.js --build",
29+
"test:types:ts60": "node ../../node_modules/typescript60/lib/tsc.js --build tsconfig.legacy.json",
3030
"test:lib": "vitest --retry=3",
3131
"test:lib:dev": "pnpm run test:lib --watch",
3232
"test:build": "publint --strict && attw --pack",

packages/solid-query/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"test:types:ts58": "node ../../node_modules/typescript58/lib/tsc.js --build tsconfig.legacy.json",
2727
"test:types:ts59": "node ../../node_modules/typescript59/lib/tsc.js --build tsconfig.legacy.json",
2828
"test:types:tscurrent": "tsc --build",
29-
"test:types:ts60": "node ../../node_modules/typescript60/lib/tsc.js --build",
29+
"test:types:ts60": "node ../../node_modules/typescript60/lib/tsc.js --build tsconfig.legacy.json",
3030
"test:lib": "vitest --retry=3",
3131
"test:lib:dev": "pnpm run test:lib --watch",
3232
"test:build": "publint --strict && attw --pack",

packages/vue-query/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"test:types:ts58": "node ../../node_modules/typescript58/lib/tsc.js --build tsconfig.legacy.json",
2727
"test:types:ts59": "node ../../node_modules/typescript59/lib/tsc.js --build tsconfig.legacy.json",
2828
"test:types:tscurrent": "tsc --build",
29-
"test:types:ts60": "node ../../node_modules/typescript60/lib/tsc.js --build",
29+
"test:types:ts60": "node ../../node_modules/typescript60/lib/tsc.js --build tsconfig.legacy.json",
3030
"test:lib": "pnpm run test:lib:2 && pnpm run test:lib:2.7 && pnpm run test:lib:3",
3131
"test:lib:2": "vue-demi-switch 2 vue2 && vitest",
3232
"test:lib:2.7": "vue-demi-switch 2.7 vue2.7 && vitest",

0 commit comments

Comments
 (0)