fix(types): do not drop readonly for partial QueryFilter matching

TkDodo · TkDodo · commit 6c0c7978db89 · 2025-11-14T09:06:43.000+01:00
diff --git a/packages/query-core/src/__tests__/utils.test-d.tsx b/packages/query-core/src/__tests__/utils.test-d.tsx
@@ -50,7 +50,7 @@ describe('QueryFilters', () => {
     expectTypeOf(filters.queryKey).toEqualTypeOf<
       | undefined
       | readonly []
-      | ['key']
+      | readonly ['key']
       | readonly [
           'key',
           {
@@ -61,6 +61,18 @@ describe('QueryFilters', () => {
     >()
   })
 
+  it('should work with readonly union types', () => {
+    const filters: QueryFilters<
+      readonly ['key'] | readonly ['key', 'something']
+    > = {
+      queryKey: ['key'],
+    }
+
+    expectTypeOf(filters.queryKey).toEqualTypeOf<
+      undefined | readonly [] | readonly ['key'] | readonly ['key', 'something']
+    >()
+  })
+
   it('should error on invalid query keys', () => {
     assertType<QueryFilters<readonly ['key', { a: number; b: string }]>>({
       // @ts-expect-error cannot pass invalid query key
diff --git a/packages/query-core/src/utils.ts b/packages/query-core/src/utils.ts
@@ -20,7 +20,7 @@ type DropLast<T extends ReadonlyArray<unknown>> = T extends readonly [
   ...infer R,
   unknown,
 ]
-  ? R
+  ? readonly [...R]
   : never
 
 type TuplePrefixes<T extends ReadonlyArray<unknown>> = T extends readonly []

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ type DropLast<T extends ReadonlyArray<unknown>> = T extends readonly [`
`20`	`20`	`...infer R,`
`21`	`21`	`unknown,`
`22`	`22`	`]`
`23`		`- ? R`
	`23`	`+ ? readonly [...R]`
`24`	`24`	`: never`
`25`	`25`
`26`	`26`	`type TuplePrefixes<T extends ReadonlyArray<unknown>> = T extends readonly []`