make tests better

TkDodo · TkDodo · commit 4206f7919e5e · 2026-02-28T16:58:19.000+01:00
diff --git a/packages/query-core/src/__tests__/environmentManager.test.tsx b/packages/query-core/src/__tests__/environmentManager.test.tsx
@@ -19,7 +19,11 @@ describe('environmentManager', () => {
   })
 
   test('should allow overriding isServer with a function', () => {
-    environmentManager.setIsServer(() => true)
+    let server = true
+    environmentManager.setIsServer(() => server)
     expect(environmentManager.isServer()).toBe(true)
+
+    server = false
+    expect(environmentManager.isServer()).toBe(false)
   })
 })
diff --git a/packages/query-core/src/__tests__/focusManager.test.tsx b/packages/query-core/src/__tests__/focusManager.test.tsx
@@ -61,11 +61,15 @@ describe('focusManager', () => {
     const removeEventListenerSpy = vi.spyOn(globalThis, 'removeEventListener')
 
     const subscribe = () => focusManager.subscribe(() => undefined)
+    let firstUnsubscribe: (() => void) | undefined
 
-    expect(subscribe).not.toThrow()
-    const unsubscribe = subscribe()
+    expect(() => {
+      firstUnsubscribe = subscribe()
+    }).not.toThrow()
+    const secondUnsubscribe = subscribe()
 
-    unsubscribe()
+    firstUnsubscribe?.()
+    secondUnsubscribe()
 
     expect(removeEventListenerSpy).not.toHaveBeenCalled()
 
diff --git a/packages/query-core/src/__tests__/onlineManager.test.tsx b/packages/query-core/src/__tests__/onlineManager.test.tsx
@@ -69,10 +69,8 @@ describe('onlineManager', () => {
     )
     const removeEventListenerSpy = vi.spyOn(globalThis, 'removeEventListener')
 
-    const subscribe = () => onlineManager.subscribe(() => undefined)
-
-    expect(subscribe).not.toThrow()
-    const unsubscribe = subscribe()
+    const unsubscribe = onlineManager.subscribe(() => undefined)
+    expect(unsubscribe).toBeInstanceOf(Function)
 
     unsubscribe()
 
