Skip to content

Commit 28e98fa

Browse files
ci: apply automated fixes
1 parent c6cfbf0 commit 28e98fa

2 files changed

Lines changed: 52 additions & 41 deletions

File tree

packages/eslint-plugin-query/src/__tests__/no-unstable-deps.test.ts

Lines changed: 38 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,11 @@ const baseTestCases = {
2828
}
2929
`,
3030
},
31-
].concat(
32-
useQueryHookNames.map((queryHook) => ({
33-
name: `should pass result of ${queryHook} is passed to ${reactHookInvocation} as dependency`,
34-
code: `
31+
]
32+
.concat(
33+
useQueryHookNames.map((queryHook) => ({
34+
name: `should pass result of ${queryHook} is passed to ${reactHookInvocation} as dependency`,
35+
code: `
3536
${reactHookImport}
3637
import { ${queryHook} } from "@tanstack/react-query";
3738
@@ -41,11 +42,12 @@ const baseTestCases = {
4142
return;
4243
}
4344
`,
44-
})),
45-
).concat([
46-
{
47-
name: `should pass when useQueries with combine is passed to ${reactHookAlias} as dependency`,
48-
code: `
45+
})),
46+
)
47+
.concat([
48+
{
49+
name: `should pass when useQueries with combine is passed to ${reactHookAlias} as dependency`,
50+
code: `
4951
${reactHookImport}
5052
import { useQueries } from "@tanstack/react-query";
5153
@@ -60,8 +62,8 @@ const baseTestCases = {
6062
return;
6163
}
6264
`,
63-
},
64-
]),
65+
},
66+
]),
6567
invalid: ({
6668
reactHookImport,
6769
reactHookInvocation,
@@ -87,10 +89,11 @@ const baseTestCases = {
8789
},
8890
],
8991
},
90-
].concat(
91-
useQueryHookNames.map((queryHook) => ({
92-
name: `result of ${queryHook} is passed to ${reactHookInvocation} as dependency`,
93-
code: `
92+
]
93+
.concat(
94+
useQueryHookNames.map((queryHook) => ({
95+
name: `result of ${queryHook} is passed to ${reactHookInvocation} as dependency`,
96+
code: `
9497
${reactHookImport}
9598
import { ${queryHook} } from "@tanstack/react-query";
9699
@@ -100,17 +103,18 @@ const baseTestCases = {
100103
return;
101104
}
102105
`,
103-
errors: [
104-
{
105-
messageId: 'noUnstableDeps',
106-
data: { reactHook: reactHookAlias, queryHook },
107-
},
108-
],
109-
})),
110-
).concat([
111-
{
112-
name: `result of useQueries without combine is passed to ${reactHookInvocation} as dependency`,
113-
code: `
106+
errors: [
107+
{
108+
messageId: 'noUnstableDeps',
109+
data: { reactHook: reactHookAlias, queryHook },
110+
},
111+
],
112+
})),
113+
)
114+
.concat([
115+
{
116+
name: `result of useQueries without combine is passed to ${reactHookInvocation} as dependency`,
117+
code: `
114118
${reactHookImport}
115119
import { useQueries } from "@tanstack/react-query";
116120
@@ -124,14 +128,14 @@ const baseTestCases = {
124128
return;
125129
}
126130
`,
127-
errors: [
128-
{
129-
messageId: 'noUnstableDeps',
130-
data: { reactHook: reactHookAlias, queryHook: 'useQueries' },
131-
},
132-
],
133-
},
134-
]),
131+
errors: [
132+
{
133+
messageId: 'noUnstableDeps',
134+
data: { reactHook: reactHookAlias, queryHook: 'useQueries' },
135+
},
136+
],
137+
},
138+
]),
135139
}
136140

137141
const testCases = (reactHookName: string) => [

packages/eslint-plugin-query/src/rules/no-unstable-deps/no-unstable-deps.rule.ts

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -67,16 +67,20 @@ export const rule = createRule({
6767
}
6868
}
6969

70-
function hasCombineProperty(callExpression: TSESTree.CallExpression): boolean {
70+
function hasCombineProperty(
71+
callExpression: TSESTree.CallExpression,
72+
): boolean {
7173
if (callExpression.arguments.length === 0) return false
7274

7375
const firstArg = callExpression.arguments[0]
74-
if (!firstArg || firstArg.type !== AST_NODE_TYPES.ObjectExpression) return false
76+
if (!firstArg || firstArg.type !== AST_NODE_TYPES.ObjectExpression)
77+
return false
7578

76-
return firstArg.properties.some(prop =>
77-
prop.type === AST_NODE_TYPES.Property &&
78-
prop.key.type === AST_NODE_TYPES.Identifier &&
79-
prop.key.name === 'combine'
79+
return firstArg.properties.some(
80+
(prop) =>
81+
prop.type === AST_NODE_TYPES.Property &&
82+
prop.key.type === AST_NODE_TYPES.Identifier &&
83+
prop.key.name === 'combine',
8084
)
8185
}
8286

@@ -108,7 +112,10 @@ export const rule = createRule({
108112
allHookNames.includes(node.init.callee.name)
109113
) {
110114
// Special case for useQueries with combine property - it's stable
111-
if (node.init.callee.name === 'useQueries' && hasCombineProperty(node.init)) {
115+
if (
116+
node.init.callee.name === 'useQueries' &&
117+
hasCombineProperty(node.init)
118+
) {
112119
// Don't track useQueries with combine as unstable
113120
return
114121
}

0 commit comments

Comments
 (0)