Skip to content

Commit 24d8bfe

Browse files
ryansolidclaude
andcommitted
fix(solid-query): follow Solid 2.0.0-rc.9
Build with @solidjs/babel-plugin (the Solid 2.0 compiler; rc.9 moved delegated handlers to the `_$$` key, so the compiled output must match the runtime), test under vite 8 for the Solid packages, examples and the vite integration (scoped overrides; @solidjs/vite-plugin next.32+ needs vite ^8), and raise the solid-js / @solidjs/web peer floor to rc.9. useQuery: setup-time snapshots (meta projection seed, mount counts) read the cache through lookupQuery() instead of query(), which reads the version signal. Under hydration, priming writes that signal during setup and Solid holds a write made during the pass: a computation in the pass that reads it is served the pre-write value and replays at release. For the hook's derived nodes that is the takeover; for the computation instantiating the component (a <Loading> boundary's children) it was a remount that re-created the hydrated component as a client render, so cache writes reached the DOM while the stream was open. Tests: four assertions adapted to rc.9's committed-frame model (a write becomes visible at flush, to every channel): status/isPending read the held frame mid-hold, isFetching is the pending probe; the mutation settle commits fresh data and the lifted overlay in one frame. Co-Authored-By: Claude Fable 5.1 <[email protected]>
1 parent 1b43d5e commit 24d8bfe

21 files changed

Lines changed: 1303 additions & 781 deletions

File tree

‎.changeset/solid-rc9.md‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
'@tanstack/solid-query': patch
3+
'@tanstack/solid-query-devtools': patch
4+
'@tanstack/solid-query-persist-client': patch
5+
---
6+
7+
Follow Solid 2.0.0-rc.9. The packages build with `@solidjs/babel-plugin` (the Solid 2.0 compiler, matching the rc.9 runtime's delegated-event contract) and test under vite 8; the `solid-js` / `@solidjs/web` peer floor is `2.0.0-rc.9`.
8+
9+
`useQuery`'s setup-time snapshots (the meta projection's seed, the mount counts) now read the cache directly instead of through the hook's version signal. Under hydration, priming writes that signal during setup, and a write made during the hydration pass is held: a computation in the pass that reads it — tracked or not — is served the pre-write value and replays when the pass ends. For the hook's own derived nodes that replay is the takeover; for the computation instantiating the component (a `<Loading>` boundary's children) it was a remount, re-creating the hydrated component as a client render and letting cache writes reach the DOM while the stream was still open.

‎examples/solid/astro/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
"@tanstack/solid-query": "^6.0.0-rc.4",
1919
"@tanstack/solid-query-devtools": "^6.0.0-rc.4",
2020
"astro": "^5.5.6",
21-
"@solidjs/web": "^2.0.0-rc.0",
22-
"solid-js": "^2.0.0-rc.0",
21+
"@solidjs/web": "^2.0.0-rc.9",
22+
"solid-js": "^2.0.0-rc.9",
2323
"tailwindcss": "^3.4.7",
2424
"typescript": "5.8.3"
2525
}

‎examples/solid/basic-graphql-request/package.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
"@tanstack/solid-query-devtools": "^6.0.0-rc.4",
1313
"graphql": "^16.9.0",
1414
"graphql-request": "^7.1.2",
15-
"@solidjs/web": "^2.0.0-rc.0",
16-
"solid-js": "^2.0.0-rc.0"
15+
"@solidjs/web": "^2.0.0-rc.9",
16+
"solid-js": "^2.0.0-rc.9"
1717
},
1818
"devDependencies": {
19-
"@solidjs/vite-plugin": "^3.0.0-next.27",
19+
"@solidjs/vite-plugin": "^3.0.0-next.44",
2020
"typescript": "5.8.3",
21-
"vite": "^6.4.1"
21+
"vite": "^8.3.0"
2222
}
2323
}

‎examples/solid/basic/package.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
"dependencies": {
1111
"@tanstack/solid-query": "^6.0.0-rc.4",
1212
"@tanstack/solid-query-devtools": "^6.0.0-rc.4",
13-
"@solidjs/web": "^2.0.0-rc.0",
14-
"solid-js": "^2.0.0-rc.0"
13+
"@solidjs/web": "^2.0.0-rc.9",
14+
"solid-js": "^2.0.0-rc.9"
1515
},
1616
"devDependencies": {
17-
"@solidjs/vite-plugin": "^3.0.0-next.27",
17+
"@solidjs/vite-plugin": "^3.0.0-next.44",
1818
"typescript": "5.8.3",
19-
"vite": "^6.4.1"
19+
"vite": "^8.3.0"
2020
}
2121
}

‎examples/solid/default-query-function/package.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
"dependencies": {
1111
"@tanstack/solid-query": "^6.0.0-rc.4",
1212
"@tanstack/solid-query-devtools": "^6.0.0-rc.4",
13-
"@solidjs/web": "^2.0.0-rc.0",
14-
"solid-js": "^2.0.0-rc.0"
13+
"@solidjs/web": "^2.0.0-rc.9",
14+
"solid-js": "^2.0.0-rc.9"
1515
},
1616
"devDependencies": {
17-
"@solidjs/vite-plugin": "^3.0.0-next.27",
17+
"@solidjs/vite-plugin": "^3.0.0-next.44",
1818
"typescript": "5.8.3",
19-
"vite": "^6.4.1"
19+
"vite": "^8.3.0"
2020
}
2121
}

‎examples/solid/offline/package.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@
1313
"@tanstack/solid-query-devtools": "^6.0.0-rc.4",
1414
"@tanstack/solid-query-persist-client": "^6.0.0-rc.4",
1515
"msw": "^2.6.6",
16-
"@solidjs/web": "^2.0.0-rc.0",
17-
"solid-js": "^2.0.0-rc.0"
16+
"@solidjs/web": "^2.0.0-rc.9",
17+
"solid-js": "^2.0.0-rc.9"
1818
},
1919
"devDependencies": {
20-
"@solidjs/vite-plugin": "^3.0.0-next.27",
20+
"@solidjs/vite-plugin": "^3.0.0-next.44",
2121
"typescript": "5.8.3",
22-
"vite": "^6.4.1"
22+
"vite": "^8.3.0"
2323
},
2424
"msw": {
2525
"workerDirectory": [

‎examples/solid/simple/package.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@
1010
"dependencies": {
1111
"@tanstack/solid-query": "^6.0.0-rc.4",
1212
"@tanstack/solid-query-devtools": "^6.0.0-rc.4",
13-
"@solidjs/web": "^2.0.0-rc.0",
14-
"solid-js": "^2.0.0-rc.0"
13+
"@solidjs/web": "^2.0.0-rc.9",
14+
"solid-js": "^2.0.0-rc.9"
1515
},
1616
"devDependencies": {
17-
"@solidjs/vite-plugin": "^3.0.0-next.27",
17+
"@solidjs/vite-plugin": "^3.0.0-next.44",
1818
"@tanstack/eslint-plugin-query": "^5.101.4",
1919
"typescript": "5.8.3",
20-
"vite": "^6.4.1"
20+
"vite": "^8.3.0"
2121
}
2222
}

‎examples/solid/solid-start-streaming/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
"@solidjs/start": "^1.1.3",
1515
"@tanstack/solid-query": "^6.0.0-rc.4",
1616
"@tanstack/solid-query-devtools": "^6.0.0-rc.4",
17-
"@solidjs/web": "^2.0.0-rc.0",
18-
"solid-js": "^2.0.0-rc.0",
17+
"@solidjs/web": "^2.0.0-rc.9",
18+
"solid-js": "^2.0.0-rc.9",
1919
"vinxi": "^0.5.3"
2020
},
2121
"engines": {

‎integrations/solid-vite/package.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
"dependencies": {
99
"@tanstack/solid-query": "workspace:*",
1010
"@tanstack/solid-query-devtools": "workspace:*",
11-
"solid-js": "^2.0.0-rc.0",
12-
"vite": "^6.4.1",
13-
"@solidjs/web": "^2.0.0-rc.0",
14-
"@solidjs/vite-plugin": "^3.0.0-next.27"
11+
"solid-js": "^2.0.0-rc.9",
12+
"vite": "^8.3.0",
13+
"@solidjs/web": "^2.0.0-rc.9",
14+
"@solidjs/vite-plugin": "^3.0.0-next.44"
1515
}
1616
}

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"test:pr": "nx affected --targets=test:sherif,test:knip,test:docs,test:eslint,test:lib,test:types,test:build,build",
1717
"test:ci": "nx run-many --targets=test:sherif,test:knip,test:docs,test:eslint,test:lib,test:types,test:build,build",
1818
"test:eslint": "nx affected --target=test:eslint",
19-
"test:sherif": "sherif -i typescript -i solid-js -p \"./integrations/*\" -p \"./examples/*\"",
19+
"test:sherif": "sherif -i typescript -i solid-js -i vite -p \"./integrations/*\" -p \"./examples/*\"",
2020
"test:size": "size-limit",
2121
"test:lib": "nx affected --target=test:lib --exclude=examples/**",
2222
"test:lib:dev": "pnpm run test:lib && nx watch --all -- pnpm run test:lib",

0 commit comments

Comments
 (0)