fix(query-core): ensure onMutate runs synchronously when cache config is undefined

xxziiko · xxziiko · commit 1e71dcbfff45 · 2026-01-22T21:37:50.000+09:00
Fixes #8724
diff --git a/packages/query-core/src/__tests__/mutationCache.test.tsx b/packages/query-core/src/__tests__/mutationCache.test.tsx
@@ -249,6 +249,30 @@ describe('mutationCache', () => {
 
       expect(states).toEqual([1, 2, 3, 4])
     })
+
+    test('options.onMutate should run synchronously when mutationCache.config.onMutate is not defined', () => {
+      const key = queryKey()
+      const states: Array<string> = []
+
+      // No onMutate in cache config
+      const testCache = new MutationCache({})
+      const testClient = new QueryClient({ mutationCache: testCache })
+
+      executeMutation(
+        testClient,
+        {
+          mutationKey: key,
+          mutationFn: () => sleep(10).then(() => ({ data: 5 })),
+          onMutate: () => {
+            states.push('onMutate')
+            return 'context'
+          },
+        },
+        'vars',
+      )
+
+      expect(states).toEqual(['onMutate'])
+    })
   })
 
   describe('find', () => {
diff --git a/packages/query-core/src/mutation.ts b/packages/query-core/src/mutation.ts
@@ -212,11 +212,13 @@ export class Mutation<
       } else {
         this.#dispatch({ type: 'pending', variables, isPaused })
         // Notify cache callback
-        await this.#mutationCache.config.onMutate?.(
-          variables,
-          this as Mutation<unknown, unknown, unknown, unknown>,
-          mutationFnContext,
-        )
+        if (this.#mutationCache.config.onMutate) {
+          await this.#mutationCache.config.onMutate(
+            variables,
+            this as Mutation<unknown, unknown, unknown, unknown>,
+            mutationFnContext,
+          )
+        }
         const context = await this.options.onMutate?.(
           variables,
           mutationFnContext,
