Skip to content

fix chains joins#511

Merged
samwillis merged 5 commits intomainfrom
samwillis/fix-chained-joins
Sep 8, 2025
Merged

fix chains joins#511
samwillis merged 5 commits intomainfrom
samwillis/fix-chained-joins

Conversation

@samwillis
Copy link
Copy Markdown
Collaborator

@samwillis samwillis commented Sep 8, 2025

Fixes #474 - the bug is entirely with the validation logic.

replaces #475

@samwillis samwillis requested a review from kevin-dp September 8, 2025 14:39
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 79dde3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@tanstack/db Patch
@tanstack/electric-db-collection Patch
@tanstack/query-db-collection Patch
@tanstack/react-db Patch
@tanstack/solid-db Patch
@tanstack/svelte-db Patch
@tanstack/trailbase-db-collection Patch
@tanstack/vue-db Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Sep 8, 2025 •
edited
Loading

More templates

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@511

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@511

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@511

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@511

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@511

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@511

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@511

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@511

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@511

commit: 79dde3b

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 8, 2025 •
edited
Loading

Size Change: +72 B (+0.11%)

Total Size: 65.1 kB

Filename Size Change
./packages/db/dist/esm/errors.js 3.1 kB -4 B (-0.13%)
./packages/db/dist/esm/index.js 1.53 kB +15 B (+0.99%)
./packages/db/dist/esm/query/compiler/joins.js 2.5 kB +61 B (+2.5%)
ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/change-events.js 1.13 kB
./packages/db/dist/esm/collection.js 10.5 kB
./packages/db/dist/esm/deferred.js 230 B
./packages/db/dist/esm/indexes/auto-index.js 745 B
./packages/db/dist/esm/indexes/base-index.js 605 B
./packages/db/dist/esm/indexes/btree-index.js 1.74 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.25 kB
./packages/db/dist/esm/local-only.js 827 B
./packages/db/dist/esm/local-storage.js 2.03 kB
./packages/db/dist/esm/optimistic-action.js 294 B
./packages/db/dist/esm/proxy.js 3.87 kB
./packages/db/dist/esm/query/builder/functions.js 575 B
./packages/db/dist/esm/query/builder/index.js 3.83 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 890 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.48 kB
./packages/db/dist/esm/query/compiler/expressions.js 631 B
./packages/db/dist/esm/query/compiler/group-by.js 2.08 kB
./packages/db/dist/esm/query/compiler/index.js 2.16 kB
./packages/db/dist/esm/query/compiler/order-by.js 1.23 kB
./packages/db/dist/esm/query/compiler/select.js 655 B
./packages/db/dist/esm/query/ir.js 466 B
./packages/db/dist/esm/query/live-query-collection.js 333 B
./packages/db/dist/esm/query/live/collection-config-builder.js 2.58 kB
./packages/db/dist/esm/query/live/collection-subscriber.js 2.4 kB
./packages/db/dist/esm/query/optimizer.js 2.64 kB
./packages/db/dist/esm/SortedMap.js 1.24 kB
./packages/db/dist/esm/transactions.js 2.29 kB
./packages/db/dist/esm/utils.js 943 B
./packages/db/dist/esm/utils/btree.js 6.02 kB
./packages/db/dist/esm/utils/comparison.js 718 B
./packages/db/dist/esm/utils/index-optimization.js 1.62 kB

compressed-size-action::db-package-size

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 8, 2025 •
edited
Loading

Size Change: 0 B

Total Size: 1.18 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 152 B
./packages/react-db/dist/esm/useLiveQuery.js 1.02 kB

compressed-size-action::react-db-package-size

This was referenced Sep 8, 2025
Closed
Closed
kevin-dp
kevin-dp approved these changes Sep 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kevin-dp kevin-dp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

Comment thread .changeset/seven-eggs-beam.md Outdated
"@tanstack/db": patch
---

fix a bug that prevented chains joins (joining collectionB to collectionA, then collectionC to collectionB) within one query without using a subquery
Copy link
Copy Markdown
Contributor

@kevin-dp kevin-dp Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that prevented chains joins

there's a typo, should be "chaining joins"

@samwillis samwillis merged commit 51954d8 into main Sep 8, 2025
9 of 10 checks passed
@samwillis samwillis deleted the samwillis/fix-chained-joins branch September 8, 2025 16:51
@github-actions github-actions Bot mentioned this pull request Sep 8, 2025
Merged
Uziniii pushed a commit to Uziniii/db that referenced this pull request Sep 19, 2025
@samwillis @Uziniii
fix chains joins (TanStack#511)
f4727a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevin-dp kevin-dp kevin-dp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple Joins "Invalid join condition"

2 participants

@samwillis @kevin-dp