Skip to content

fix: improve InvalidSourceError message clarity#488

Merged
KyleAMathews merged 4 commits intomainfrom
improve-invalid-source-error-message
Sep 3, 2025
Merged

fix: improve InvalidSourceError message clarity#488
KyleAMathews merged 4 commits intomainfrom
improve-invalid-source-error-message

Conversation

@KyleAMathews
Copy link
Copy Markdown
Collaborator

@KyleAMathews KyleAMathews commented Sep 3, 2025

Summary

  • Improves the InvalidSourceError message to be more descriptive and actionable
  • Adds the alias name to help identify which source is causing the problem
  • Provides clear guidance on what should be passed instead (Collection instances)
  • Changes from generic "Invalid source" to specific error about non-Collection values

Test plan

  • All existing tests pass (1,281 tests across packages)
  • Build completes successfully
  • Linting passes
  • Error message now includes helpful debugging information

Error message before/after

Before:

Invalid source

After:

Invalid source for live query: The value provided for alias "myAlias" is not a Collection. Live queries only accept Collection instances. Please ensure you're passing a valid Collection object, not a plain array or other data type.

🤖 Generated with Claude Code

@KyleAMathews @claude
fix: improve InvalidSourceError message clarity
79ecb38 
The InvalidSourceError now provides a clear, actionable error message that:
- Explicitly states the problem is passing a non-Collection to a live query
- Includes the alias name to help identify which source is problematic
- Provides guidance on what should be passed instead (Collection instances)

This replaces the generic "Invalid source" message with helpful debugging information.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 8eabb42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@tanstack/db Patch
@tanstack/electric-db-collection Patch
@tanstack/query-db-collection Patch
@tanstack/react-db Patch
@tanstack/solid-db Patch
@tanstack/svelte-db Patch
@tanstack/trailbase-db-collection Patch
@tanstack/vue-db Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Sep 3, 2025 •
edited
Loading

More templates

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@488

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@488

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@488

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@488

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@488

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@488

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@488

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@488

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@488

commit: 8eabb42

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 3, 2025 •
edited
Loading

Size Change: +101 B (+0.16%)

Total Size: 65 kB

Filename Size Change
./packages/db/dist/esm/errors.js 3.1 kB +98 B (+3.26%)
./packages/db/dist/esm/query/builder/index.js 3.83 kB +3 B (+0.08%)
ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/change-events.js 1.13 kB
./packages/db/dist/esm/collection.js 10.5 kB
./packages/db/dist/esm/deferred.js 230 B
./packages/db/dist/esm/index.js 1.52 kB
./packages/db/dist/esm/indexes/auto-index.js 745 B
./packages/db/dist/esm/indexes/base-index.js 605 B
./packages/db/dist/esm/indexes/btree-index.js 1.74 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.25 kB
./packages/db/dist/esm/local-only.js 827 B
./packages/db/dist/esm/local-storage.js 2.03 kB
./packages/db/dist/esm/optimistic-action.js 294 B
./packages/db/dist/esm/proxy.js 3.87 kB
./packages/db/dist/esm/query/builder/functions.js 575 B
./packages/db/dist/esm/query/builder/ref-proxy.js 890 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.48 kB
./packages/db/dist/esm/query/compiler/expressions.js 631 B
./packages/db/dist/esm/query/compiler/group-by.js 2.09 kB
./packages/db/dist/esm/query/compiler/index.js 2.16 kB
./packages/db/dist/esm/query/compiler/joins.js 2.36 kB
./packages/db/dist/esm/query/compiler/order-by.js 1.23 kB
./packages/db/dist/esm/query/compiler/select.js 655 B
./packages/db/dist/esm/query/ir.js 466 B
./packages/db/dist/esm/query/live-query-collection.js 333 B
./packages/db/dist/esm/query/live/collection-config-builder.js 2.58 kB
./packages/db/dist/esm/query/live/collection-subscriber.js 2.4 kB
./packages/db/dist/esm/query/optimizer.js 2.63 kB
./packages/db/dist/esm/SortedMap.js 1.24 kB
./packages/db/dist/esm/transactions.js 2.29 kB
./packages/db/dist/esm/utils.js 943 B
./packages/db/dist/esm/utils/btree.js 6.02 kB
./packages/db/dist/esm/utils/comparison.js 718 B
./packages/db/dist/esm/utils/index-optimization.js 1.62 kB

compressed-size-action::db-package-size

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 3, 2025 •
edited
Loading

Size Change: 0 B

Total Size: 1.16 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 152 B
./packages/react-db/dist/esm/useLiveQuery.js 1.01 kB

compressed-size-action::react-db-package-size

samwillis
samwillis requested changes Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error should make clear it can be a collection or subquery. Also need changeset

Comment thread packages/db/src/errors.ts Outdated
@KyleAMathews KyleAMathews merged commit b869f68 into main Sep 3, 2025
6 checks passed
@KyleAMathews KyleAMathews deleted the improve-invalid-source-error-message branch September 3, 2025 13:00
@github-actions github-actions Bot mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samwillis samwillis samwillis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KyleAMathews @samwillis