Closed
Conversation
Co-authored-by: sam.willis <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
More templates
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: +140 B (+0.22%) Total Size: 64.8 kB
ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 1.16 kB ℹ️ View Unchanged
|
- Move chained joins test to join type test structure - Add chained joins test for all join types (inner, left, right, full) - Add incremental update testing for middle and latter collections - Verify live query updates work correctly with chained joins - Test both autoIndex off and eager modes
Merged
Collaborator
Author
|
replaced by #511 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix query builder validation to allow chained joins where subsequent joins reference previously joined collections.
The
analyzeJoinExpressionsfunction incorrectly assumed that join conditions must always reference the original base table and the newly joined table. This prevented valid chained join scenarios where a join condition correctly referenced a table introduced by a previous join. The fix updates the validation to consider all currently available table aliases for the "main" side of a join.