Refactor select improving spread (`...obj`) and enabling nested projection. by samwillis · Pull Request #389 · TanStack/db

samwillis · 2025-08-10T15:40:19Z

This branch started as a fix for the broken types when using a spread in a select (#385), but identified a couple of problems:

we didn't have any way to track the order of spreads within an object, so multiple spreads could result in incorrect overwriting of properties. This is now fixed by tracking the order of operations (ref proxy access and spreads) within the select:

.select({ user }) => ({
  ...user, // <-- spread first
  name: upper(user.name) // <-- override name
})

select didn't have proper support for nested projection, you can now do this:

select({ user }) => ({
  ...user,
  meta: {  // <= nested object within the select
    email: user.email
  }
})

closes #385
stacked on #386

Added comprehensive test coverage for querying nested objects across WHERE, SELECT, GROUP BY, and ORDER BY operations. Fixed query builder syntax issues by removing JavaScript expressions, null coalescing operators, and unnecessary optional chaining. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

changeset-bot · 2025-08-10T15:40:22Z

🦋 Changeset detected

Latest commit: 823c927

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@tanstack/db	Patch
@tanstack/electric-db-collection	Patch
@tanstack/query-db-collection	Patch
@tanstack/react-db	Patch
@tanstack/solid-db	Patch
@tanstack/svelte-db	Patch
@tanstack/trailbase-db-collection	Patch
@tanstack/vue-db	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2025-08-10T15:41:33Z

More templates

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@389

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@389

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@389

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@389

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@389

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@389

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@389

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@389

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@389

commit: 823c927

github-actions · 2025-08-10T15:45:03Z

Size Change: +1.31 kB (+2%)

Total Size: 66.5 kB

Filename	Size	Change
`./packages/db/dist/esm/query/builder/index.js`	3.93 kB	+71 B (+1.84%)
`./packages/db/dist/esm/query/builder/ref-proxy.js`	938 B	+48 B (+5.39%)	🔍
`./packages/db/dist/esm/query/compiler/index.js`	2.27 kB	+116 B (+5.38%)	🔍
`./packages/db/dist/esm/query/compiler/select.js`	1.28 kB	+623 B (+95.11%)	🆘
`./packages/db/dist/esm/query/ir.js`	508 B	+42 B (+9.01%)	🔍
`./packages/db/dist/esm/query/optimizer.js`	3.05 kB	+407 B (+15.4%)	⚠️

ℹ️ View Unchanged

Filename	Size
`./packages/db/dist/esm/change-events.js`	1.13 kB
`./packages/db/dist/esm/collection.js`	10.5 kB
`./packages/db/dist/esm/deferred.js`	230 B
`./packages/db/dist/esm/errors.js`	3.1 kB
`./packages/db/dist/esm/index.js`	1.53 kB
`./packages/db/dist/esm/indexes/auto-index.js`	745 B
`./packages/db/dist/esm/indexes/base-index.js`	605 B
`./packages/db/dist/esm/indexes/btree-index.js`	1.74 kB
`./packages/db/dist/esm/indexes/lazy-index.js`	1.25 kB
`./packages/db/dist/esm/local-only.js`	827 B
`./packages/db/dist/esm/local-storage.js`	2.03 kB
`./packages/db/dist/esm/optimistic-action.js`	294 B
`./packages/db/dist/esm/proxy.js`	3.87 kB
`./packages/db/dist/esm/query/builder/functions.js`	584 B
`./packages/db/dist/esm/query/compiler/evaluators.js`	1.54 kB
`./packages/db/dist/esm/query/compiler/expressions.js`	631 B
`./packages/db/dist/esm/query/compiler/group-by.js`	2.08 kB
`./packages/db/dist/esm/query/compiler/joins.js`	2.5 kB
`./packages/db/dist/esm/query/compiler/order-by.js`	1.23 kB
`./packages/db/dist/esm/query/live-query-collection.js`	333 B
`./packages/db/dist/esm/query/live/collection-config-builder.js`	2.58 kB
`./packages/db/dist/esm/query/live/collection-subscriber.js`	2.4 kB
`./packages/db/dist/esm/SortedMap.js`	1.24 kB
`./packages/db/dist/esm/transactions.js`	2.29 kB
`./packages/db/dist/esm/utils.js`	943 B
`./packages/db/dist/esm/utils/btree.js`	6.02 kB
`./packages/db/dist/esm/utils/comparison.js`	718 B
`./packages/db/dist/esm/utils/index-optimization.js`	1.62 kB

_{compressed-size-action::db-package-size}

kevin-dp

LGTM!
I left a few minor comments

…ction. (TanStack#389) Co-authored-by: Kyle Mathews <[email protected]> Co-authored-by: Claude <[email protected]>

KyleAMathews and others added 25 commits August 7, 2025 11:02

checkpoint

f44031d

checkpoint

57ec777

checkpoint

9f57dd6

checkpoint

e96bafd

checkpoint

3b26333

checkpoint

efa4b13

checkpoint

9f12edb

checkpoint

d5921a4

checkpoint

6c56f1d

checkpoint

046ad7d

checkpoint

9ca2797

checkpoint

818cd7b

checkpoint

7a077a8

checkpoint

ae11e1d

tests and lint pass!!

9f8b947

changeset

c3a305e

improve ref types in ide

cfb0b9e

fix spread types

7f69f04

more spread

b53892f

nested spread working

f88bd13

nested select projection

b82cb54

checkpoint

50e5203

fixed subquery select

b3adf79

tidy

0a40f1d

changeset

b9a4d73

samwillis requested a review from kevin-dp August 10, 2025 15:43

samwillis added 17 commits August 26, 2025 17:48

Merge branch 'ref-refactor' into select-refactor

b74a5de

mostly working select types...

88817e8

mostly working select types...

4cf78b0

checkpoint - nearly there

d7455bc

funcs working

175efdf

spread partialy working

66764f0

more

425664c

wip

320978f

one failing test

1e5985c

working types!

9888c5a

address first part of review

c2b7c54

refactor processSelect

0db2f0c

finish addressing review

c79de35

formatting

4ec1f68

remove redundent types

254df36

Merge branch 'main' into ref-refactor

39570bc

Merge branch 'ref-refactor' into select-refactor

a4585f0

samwillis force-pushed the select-refactor branch from 6f3ebd3 to a4585f0 Compare September 4, 2025 12:03

samwillis requested a review from kevin-dp September 4, 2025 12:05

kevin-dp approved these changes Sep 4, 2025

View reviewed changes

Comment thread packages/db/src/query/builder/index.ts Outdated

Comment thread packages/db/src/query/builder/ref-proxy.ts Outdated

Comment thread packages/db/src/query/optimizer.ts Outdated

Comment thread packages/db/src/query/optimizer.ts Outdated

address review

eb22b4f

Base automatically changed from ref-refactor to main September 8, 2025 16:59

samwillis added 2 commits September 8, 2025 18:43

Merge branch 'main' into select-refactor

cd7bec2

fix select bug

823c927

samwillis merged commit e41ed7e into main Sep 8, 2025
6 checks passed

samwillis deleted the select-refactor branch September 8, 2025 17:50

github-actions Bot mentioned this pull request Sep 8, 2025

ci: Version Packages #509

Merged

Uziniii pushed a commit to Uziniii/db that referenced this pull request Sep 19, 2025

Refactor select improving spread (...obj) and enabling nested proje…

41a95b9

…ction. (TanStack#389) Co-authored-by: Kyle Mathews <[email protected]> Co-authored-by: Claude <[email protected]>

Uziniii pushed a commit to Uziniii/db that referenced this pull request Sep 19, 2025

Refactor select improving spread (...obj) and enabling nested proje…

f83ac8c

…ction. (TanStack#389) Co-authored-by: Kyle Mathews <[email protected]> Co-authored-by: Claude <[email protected]>

Uziniii pushed a commit to Uziniii/db that referenced this pull request Sep 19, 2025

Refactor select improving spread (...obj) and enabling nested proje…

fdb62fe

…ction. (TanStack#389) Co-authored-by: Kyle Mathews <[email protected]> Co-authored-by: Claude <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor select improving spread (`...obj`) and enabling nested projection.#389

Refactor select improving spread (`...obj`) and enabling nested projection.#389
samwillis merged 53 commits intomainfrom
select-refactor

samwillis commented Aug 10, 2025 •

edited

Loading

Uh oh!

changeset-bot Bot commented Aug 10, 2025 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Aug 10, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 10, 2025 •

edited

Loading

Uh oh!

kevin-dp left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

samwillis commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new Bot commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevin-dp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

samwillis commented Aug 10, 2025 •

edited

Loading

changeset-bot Bot commented Aug 10, 2025 •

edited

Loading

pkg-pr-new Bot commented Aug 10, 2025 •

edited

Loading

github-actions Bot commented Aug 10, 2025 •

edited

Loading