fix(db): throw error when fn.select() is used with groupBy() (#1324)

kevin-dp · claude · autofix-ci[bot] · web-flow · commit a55e2bf54dbe · 2026-03-09T13:48:58.000+01:00
* fix(db): throw error when fn.select() is used with groupBy() fn.select() with groupBy() silently produced wrong results ({ __key_0: ... }) because the compiler cannot statically analyze an opaque function to discover aggregate expressions needed by groupBy. This adds a clear error message directing users to use the standard .select() API instead. Closes #1189 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * ci: apply automated fixes * chore: add changeset for fn.select + groupBy error Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
diff --git a/.changeset/fn-select-groupby-error.md b/.changeset/fn-select-groupby-error.md
@@ -0,0 +1,5 @@
+---
+'@tanstack/db': patch
+---
+
+fix(db): throw error when fn.select() is used with groupBy()
diff --git a/packages/db/src/errors.ts b/packages/db/src/errors.ts
@@ -433,6 +433,17 @@ export class DistinctRequiresSelectError extends QueryCompilationError {
   }
 }
 
+export class FnSelectWithGroupByError extends QueryCompilationError {
+  constructor() {
+    super(
+      `fn.select() cannot be used with groupBy(). ` +
+        `groupBy requires the compiler to statically analyze aggregate functions (count, sum, max, etc.) in the SELECT clause, ` +
+        `which is not possible with fn.select() since it is an opaque function. ` +
+        `Use .select() instead of .fn.select() when combining with groupBy().`,
+    )
+  }
+}
+
 export class HavingRequiresGroupByError extends QueryCompilationError {
   constructor() {
     super(`HAVING clause requires GROUP BY clause`)
diff --git a/packages/db/src/query/compiler/index.ts b/packages/db/src/query/compiler/index.ts
@@ -4,6 +4,7 @@ import {
   CollectionInputNotFoundError,
   DistinctRequiresSelectError,
   DuplicateAliasInSubqueryError,
+  FnSelectWithGroupByError,
   HavingRequiresGroupByError,
   LimitOffsetRequireOrderByError,
   UnsupportedFromTypeError,
@@ -218,6 +219,10 @@ export function compileQuery(
     throw new DistinctRequiresSelectError()
   }
 
+  if (query.fnSelect && query.groupBy && query.groupBy.length > 0) {
+    throw new FnSelectWithGroupByError()
+  }
+
   // Process the SELECT clause early - always create $selected
   // This eliminates duplication and allows for DISTINCT implementation
   if (query.fnSelect) {
diff --git a/packages/db/tests/query/group-by.test.ts b/packages/db/tests/query/group-by.test.ts
@@ -2167,6 +2167,31 @@ function createGroupByTests(autoIndex: `off` | `eager`): void {
         expect(result?.totalAmount).toBe(700)
       })
     })
+
+    describe(`fn.select with groupBy throws error`, () => {
+      let ordersCollection: ReturnType<typeof createOrdersCollection>
+
+      beforeEach(() => {
+        ordersCollection = createOrdersCollection(autoIndex)
+      })
+
+      test(`fn.select with groupBy should throw FnSelectWithGroupByError`, () => {
+        expect(() =>
+          createLiveQueryCollection({
+            startSync: true,
+            query: (q) =>
+              q
+                .from({ orders: ordersCollection })
+                .groupBy(({ orders }) => orders.customer_id)
+                .fn.select((row) => ({
+                  customerId: row.orders.customer_id,
+                  totalAmount: sum(row.orders.amount),
+                  orderCount: count(row.orders.id),
+                })),
+          }),
+        ).toThrow(`fn.select() cannot be used with groupBy()`)
+      })
+    })
   })
 }
 

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@tanstack/db': patch
 +---
++
 +fix(db): throw error when fn.select() is used with groupBy()